Skip to content

wxsqlite3: build in parallel; add test #424078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 4, 2025
Merged

wxsqlite3: build in parallel; add test #424078

merged 2 commits into from
Sep 4, 2025

Conversation

mdaniels5757
Copy link
Contributor

@mdaniels5757 mdaniels5757 commented Jul 10, 2025 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@mdaniels5757 mdaniels5757 force-pushed the add-check-wxsqlite3 branch from 50d3137 to 6816e7b Compare July 10, 2025 15:25
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Jul 10, 2025
@mdaniels5757 mdaniels5757 marked this pull request as draft July 10, 2025 15:54
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jul 10, 2025
@mdaniels5757
Copy link
Contributor Author

Illegal instruction error on x86_64-linux machines without AVX support. There is a vpxor instruction, among others.

@mdaniels5757
Copy link
Contributor Author

Filed utelle/wxsqlite3/issues/126

@mdaniels5757 mdaniels5757 added the 9.needs: upstream fix This PR needs upstream to change something label Jul 11, 2025
@mdaniels5757 mdaniels5757 force-pushed the add-check-wxsqlite3 branch 2 times, most recently from a5aa907 to a84421d Compare July 14, 2025 21:09
@mdaniels5757 mdaniels5757 changed the title wxsqlite3: add test wxsqlite3: 4.10.9 -> 4.10.10; build in parallel; add test Jul 14, 2025
@mdaniels5757

This comment was marked as outdated.

Sign in to view
@mdaniels5757 mdaniels5757 removed the 9.needs: upstream fix This PR needs upstream to change something label Jul 14, 2025
@mdaniels5757 mdaniels5757 marked this pull request as ready for review July 14, 2025 21:40
@mdaniels5757 mdaniels5757 added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jul 14, 2025
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 6, 2025
@mdaniels5757 mdaniels5757 changed the title wxsqlite3: 4.10.9 -> 4.10.10; build in parallel; add test wxsqlite3: build in parallel; add test Aug 14, 2025
@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 14, 2025
@mdaniels5757
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 424078

Logs: https://github.com/mdaniels5757/nixpkgs-review-gha/actions/runs/16954027208

x86_64-linux

✅ 4 packages built:
  • lenmus
  • mmex
  • wxsqlite3
  • wxsqliteplus

aarch64-linux

✅ 4 packages built:
  • lenmus
  • mmex
  • wxsqlite3
  • wxsqliteplus

x86_64-darwin (sandbox = true)

❌ 1 package failed to build:
  • lenmus
✅ 3 packages built:
  • mmex
  • wxsqlite3
  • wxsqliteplus
Error logs: `x86_64-darwin`
lenmus 
/nix/build/nix-build-lenmus-6.0.1.drv-3889-1533695354/source/lomse/trunk/src/parser/mnx/lomse_mnx_analyser.cpp:4263:10: warning: variable 'fErrors' set but not used [-Wunused-but-set-variable]
 4263 |     bool fErrors = false;
      |          ^
[ 95%] Building CXX object CMakeFiles/lenmus.dir/lomse/trunk/src/platform/lomse_linux.cpp.o
1 warning generated.
[ 96%] Building CXX object CMakeFiles/lenmus.dir/lomse/trunk/src/render/lomse_bitmap_drawer.cpp.o
[ 96%] Building CXX object CMakeFiles/lenmus.dir/lomse/trunk/src/render/lomse_calligrapher.cpp.o
[ 96%] Building CXX object CMakeFiles/lenmus.dir/lomse/trunk/src/render/lomse_font_freetype.cpp.o
/nix/build/nix-build-lenmus-6.0.1.drv-3889-1533695354/source/lomse/trunk/src/render/lomse_font_freetype.cpp:140:14: warning: variable 'len' set but not used [-Wunused-but-set-variable]
  140 |     unsigned len = 0;
      |              ^
/nix/build/nix-build-lenmus-6.0.1.drv-3889-1533695354/source/lomse/trunk/src/render/lomse_font_freetype.cpp:203:31: error: assigning to 'char *' from 'unsigned char *' converts between pointers to integer types where one is of the unique plain 'char' type and the other is not
  203 |         tags  = outline.tags  + first;
      |                 ~~~~~~~~~~~~~~^~~~~~~
[ 97%] Building CXX object CMakeFiles/lenmus.dir/lomse/trunk/src/render/lomse_font_storage.cpp.o
1 warning and 1 error generated.
make[2]: *** [CMakeFiles/lenmus.dir/build.make:3313: CMakeFiles/lenmus.dir/lomse/trunk/src/render/lomse_font_freetype.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:155: CMakeFiles/lenmus.dir/all] Error 2
make: *** [Makefile:156: all] Error 2

aarch64-darwin (sandbox = true)

❌ 1 package failed to build:
  • lenmus
✅ 3 packages built:
  • mmex
  • wxsqlite3
  • wxsqliteplus
Error logs: `aarch64-darwin`
lenmus 
      |          ^
[ 95%] Building CXX object CMakeFiles/lenmus.dir/lomse/trunk/src/parser/mnx/lomse_mnx_compiler.cpp.o
[ 95%] Building CXX object CMakeFiles/lenmus.dir/lomse/trunk/src/platform/lomse_linux.cpp.o
1 warning generated.
[ 96%] Building CXX object CMakeFiles/lenmus.dir/lomse/trunk/src/render/lomse_bitmap_drawer.cpp.o
[ 96%] Building CXX object CMakeFiles/lenmus.dir/lomse/trunk/src/render/lomse_calligrapher.cpp.o
[ 96%] Building CXX object CMakeFiles/lenmus.dir/lomse/trunk/src/render/lomse_font_freetype.cpp.o
[ 97%] Building CXX object CMakeFiles/lenmus.dir/lomse/trunk/src/render/lomse_font_storage.cpp.o
/nix/build/nix-build-lenmus-6.0.1.drv-6005-2239831372/source/lomse/trunk/src/render/lomse_font_freetype.cpp:140:14: warning: variable 'len' set but not used [-Wunused-but-set-variable]
  140 |     unsigned len = 0;
      |              ^
/nix/build/nix-build-lenmus-6.0.1.drv-6005-2239831372/source/lomse/trunk/src/render/lomse_font_freetype.cpp:203:31: error: assigning to 'char *' from 'unsigned char *' converts between pointers to integer types where one is of the unique plain 'char' type and the other is not
  203 |         tags  = outline.tags  + first;
      |                 ~~~~~~~~~~~~~~^~~~~~~
1 warning and 1 error generated.
make[2]: *** [CMakeFiles/lenmus.dir/build.make:3313: CMakeFiles/lenmus.dir/lomse/trunk/src/render/lomse_font_freetype.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
[ 97%] Building CXX object CMakeFiles/lenmus.dir/lomse/trunk/src/render/lomse_renderer.cpp.o
make[1]: *** [CMakeFiles/Makefile2:155: CMakeFiles/lenmus.dir/all] Error 2
make: *** [Makefile:156: all] Error 2

@mdaniels5757
Copy link
Contributor Author

I should note that lenmus is already failing on Darwin (https://hydra.nixos.org/job/nixpkgs/trunk/lenmus.x86_64-darwin https://hydra.nixos.org/job/nixpkgs/trunk/lenmus.aarch64-darwin).

@pbsds pbsds merged commit e944589 into NixOS:master Sep 4, 2025
29 of 30 checks passed
@mdaniels5757 mdaniels5757 deleted the add-check-wxsqlite3 branch September 4, 2025 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdaniels5757 @pbsds