blackmagic-desktop-video: Add optional GUI and firmware components #424621
Conversation
| cp $unpacked/usr/share/man/man1/DesktopVideo{UpdateTool,Updater}.1 $out/share/man/man1 | ||
| cp -r $unpacked/usr/share/icons/* $out/share/icons | ||
| cp $unpacked/usr/share/applications/DesktopVideoUpdater.desktop $out/share/applications | ||
| cp -r $unpacked/usr/lib/blackmagic/DesktopVideo/Firmware $out/bin/Firmware # UpdateTool expects Firmware dir next to it |
There was a problem hiding this comment.
$out/bin is only supposed to contain executable binaries, or symlinks to executable binaries. If the update tool requires the firmware next to it, I suggest putting it somewhere in opt instead. I successfully tested the following, for example:
mkdir -p $out/opt/blackmagic/DesktopVideo
cp $unpacked/usr/lib/blackmagic/DesktopVideo/DesktopVideo{UpdateTool,Updater} $out/opt/blackmagic/DesktopVideo
ln -s $out/opt/blackmagic/DesktopVideo/DesktopVideoUpdateTool $out/bin/DesktopVideoUpdateTool
ln -s $out/opt/blackmagic/DesktopVideo/DesktopVideoUpdater $out/bin/DesktopVideoUpdaterThere was a problem hiding this comment.
Truth be told, I am not 100% sure about putting the firmware dir next to the update tool. It is my best guess of how the tool works considering that I couldn't find the original path embedded anywhere in the binary. It seems to work as intended but further testing is needed. But I will go ahead assuming that Im right and put it all in opt for now
| cp -r $unpacked/usr/lib/blackmagic/DesktopVideo/plugins $out/bin/plugins | ||
| cp $unpacked/usr/lib/blackmagic/DesktopVideo/qt.conf $out/bin/ |
There was a problem hiding this comment.
Config files / subdirectories don't belong in bin
There was a problem hiding this comment.
Putting these configs and the gui binaries in opt as well, I dont have enough knowledge of qt to be certain whether these need to be next to the binary or not
Co-authored-by: Naxdy <naxdy@naxdy.org>
Co-authored-by: Naxdy <naxdy@naxdy.org>
…to binaries to bin
|
Thanks for looking this over so quick! I agree that it makes sense to include everything by default. The full version takes up about 200MB whereas the minimal version from before took only a few MB. I would suggest we change the default of |
This adds optionally adds the GUI and firmware update components under an override option. These tools can be handy for debugging, etc.
I am willing to maintain the additional components of the package, so please let me know if you would like me to do that and I can add my name to the maintainers list.
This also adds the manpage for the DesktopVideoHelper program and all docs for other programs provided
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.