maplestory-cursor: init at 1.0.0 #424590
maplestory-cursor: init at 1.0.0 #424590
Conversation
|
And welcome to nixpkgs! These are just some small changes to follow conventions, but otherwise looks good in my eyes |
|
Good job addressing issues. As I mentioned in #423912, I still want to note that this package may not have sufficient relevance.
Checkout NUR for personal packages |
bae713d to
4bc4426
Compare
Hi! Thanks for the review! I've addressed these issues |
Hi, yes, apologies for making a new PR. I usually work collaboratively on gitlab. That is a valid concern and honestly I don't know if more than 5 people will use this. The parent package 'banana-cursor' has had some success (281 stars), and this plugin builds on top of it, so it's fair to say the audience is quite small. I submitted it here because it seemed like a natural extension of what's already in nixpkgs & i'd hoped others would appreciate it. But I totally understand if it doesn't meet the bar for inclusion. |
That said, I’ve noticed that there are other packages recently merged into nixpkgs that seem similarly niche or limited in audience - for example, #422351, which appears to be a classroom project with a fairly minimal upstream presence (12 stars). I think it would be super cool if this package was merged and I'm sure I can convince my 12 friends to use this cursor theme 😜 |
|
Hi, how long is the usual queue time to get a runner for the x86-64-darwin maintainers ofborg test? It's been > 1 month. |
All checks have run fine. The maintainers on Darwin checks have been skip as this is Linux only, nothing to worry about. |
Nice! What does the usual process look like for the final merge? |
Usually, like a long wait until a committer give it a look. If running with luck you can get it merge in like 2 weeks, but it's been more than that, so this one seems like the long wait ones. (from some weeks to a few months 🥲) Too many PRs and too little committers. But hopefully you will get it soon |
|
Ah alright, no worries at all. Thank you for all the guidance :) |
My first nix package, a maplestory inspired cursor theme. Works on both x11 and wayland. A fork of the popular banana-cursor.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.