releaseTools, vmTools: remove old builders #423355
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d27b0a0 to
b54ddf3
Compare
6057db2 to
2e33c76
Compare
emilazy
requested changes
Jul 17, 2025
| /* | ||
| Like `rpmClosureGenerator', but now for Debian/Ubuntu releases | ||
| closure of a set of top-level deb packages from the | ||
| `primary.xml.gz' file of a Debian/Ubuntu release. |
There was a problem hiding this comment.
primary.xml.gz is an RPM thing, so this comment can’t be correct.
Comment on lines
-985
to
-988
| # The set of supported RPM-based distributions. | ||
|
|
||
| rpmDistros = { }; | ||
|
|
There was a problem hiding this comment.
FWIW, I deliberately left this stuff around when removing all the existing EOL versions in case anyone wanted to re‐add support for newer ones. But it’ll survive in the commit log anyway, so meh.
Comment on lines
-42
to
-58
| binaryTarball = | ||
| args: | ||
| import ./binary-tarball.nix ( | ||
| { | ||
| inherit lib stdenv; | ||
| } | ||
| // args | ||
| ); | ||
|
|
||
| mvnBuild = | ||
| args: | ||
| import ./maven-build.nix ( | ||
| { | ||
| inherit lib stdenv; | ||
| } | ||
| // args | ||
| ); |
There was a problem hiding this comment.
Are these broken, or is this just on a principle of “nothing is using them and it seems like nobody cares”? (I don’t mind dropping them, to be clear.)
Comment on lines
+24
to
+28
| binaryTarball = throw "removed (8 Jul 2025)"; | ||
| debBuild = throw "removed (8 Jul 2025)"; | ||
| makeSourceTarball = throw "removed (8 Jul 2025); use releaseTools.sourceTarball"; | ||
| mvnBuild = throw "removed (8 Jul 2025)"; | ||
| rpmBuild = throw "removed (8 Jul 2025)"; |
There was a problem hiding this comment.
Can you make these more like the removal messages in pkgs/top-level/aliases.nix? Right now they’d be pretty confusing without a stack trace. (Thankfully it seems like we don’t recurse into here so we don’t need to guard these with an aliases check.)
2e33c76 to
b94aac8
Compare
Broken, unused, undocumented and unmaintained. Fails with 'mkdir: command not found' when building any image because the postHook runs before the VM is started in addition to inside the VM.
Undocumented, unmaintained and unused.
Undocumented, unmaintained and unused.
Undocumented, unmaintained and unused.
This is a compatibility alias added in 2009. I think it's time for it to go.
b94aac8 to
ddf5103
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some very old unused and undocumented builders from releaseTools. In particular, debBuild depends on the insecure checkinstall and is currently broken.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.