nixos/urlwatch: init module #423275
Open
nixos/urlwatch: init module #423275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1fed594 to
334f8bb
Compare
334f8bb to
f4b43b8
Compare
f4b43b8 to
58e5424
Compare
acid-bong
reviewed
Jul 7, 2025
0501848 to
6517cce
Compare
awwpotato
suggested changes
Jul 9, 2025
691108e to
8a42680
Compare
Added systemd service for urlwatch.
8a42680 to
ab86d30
Compare
Comment on lines
+11
to
+16
| urlsFile = lib.pipe cfg.jobs [ | ||
| (map (format.generate "jobfile")) | ||
| (map builtins.readFile) | ||
| (builtins.concatStringsSep "---\n") | ||
| (pkgs.writeText "urls.yaml") | ||
| ]; |
There was a problem hiding this comment.
Suggested change
| urlsFile = lib.pipe cfg.jobs [ | |
| (map (format.generate "jobfile")) | |
| (map builtins.readFile) | |
| (builtins.concatStringsSep "---\n") | |
| (pkgs.writeText "urls.yaml") | |
| ]; | |
| urlsFile = lib.concatMapStringsSep "---\n" (x: ) .... |
i think concatMapStringsSep is more what you're looking for ;p
| wants = [ "network-online.target" ]; | ||
| wantedBy = [ "multi-user.target" ]; | ||
| path = [ cfg.package ]; | ||
| serviceConfig = { |
There was a problem hiding this comment.
Would be nice to see some more hardening options, check out systemd-hardening-helper
Co-authored-by: jack rosenberg <56937175+jackrosenberg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Urlwatch is used to monitor websites for changes.
This pr adds a module to create a system service continuously polling changes.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.