graalvm-oracle_24: init at 24.0.2 #423224

farnoy · 2025-07-07T14:32:46Z

Things done

Add a 👍 reaction to pull requests you find important.

msgilligan · 2025-07-13T19:08:57Z

This should resolve Issue #423071 and overlaps with PR #423088.

msgilligan

I like how this PR adds 24 without removing 23. I would like to see this (eventually) become the standard way Nixpkgs migrates to new JDKs. (i.e. new JDK versions are added and previous non-LTS versions are removed a short time later)

Note that there is also a formatting error with this PR.

msgilligan · 2025-07-13T22:50:50Z

pkgs/development/compilers/graalvm/graalvm-oracle/default.nix

+  propagatedBuildInputs = (prev.propagatedBuildInputs or []) ++ [ onnxruntime ];
+  postFixup = (prev.postFixup or "") + ''
+    patchelf --replace-needed libonnxruntime.so.1.18.0 libonnxruntime.so.1 $out/lib/svm/profile_inference/onnx/native/libonnxruntime4j_jni.so
+  '';


How does this differ from the autoPatchelfIgnoreMissingDeps approach used in PR #423088 ?

@emaryn I think your version of this PR was probably best, it's too bad you closed it. I was mostly just trying to get it to work first and what you reviewed was not a cleaned u pversion, but I agree that patchelf step should only be done on 24 onwards.

I think the issue requesting an update to the package and our PRs all landed in quick succession, I was not aware of either that issue or your PR when I worked on this.

As for keeping older versions around, I'm not sure what the best policy is, maintaining these versions is probably not a big deal (until the build system changes but I think that's unlikely), but a warning about EOL would be nice to have.

@farnoy I would recommend creating a PR to remove the JDK 23 version immediately after this one is merged.

And the rest of @emaryn's PR should be implemented (as yet another PR I would suggest) to add JDK 21 and EOL JDK 17.

Fix Nix formatting issue that is failing GitHub Actions checks. This should be squashed into PR NixOS#423224

msgilligan · 2025-07-14T06:50:30Z

@farnoy I made a draft PR that adds a commit fixing the formatting issues that are causing the two failing checks: PR #425010.

The second commit has the changes you need. Feel free to squash it into your PR. See farnoy@4b09641

msgilligan · 2025-07-14T15:26:20Z

@farnoy I made a draft PR that adds a commit fixing the formatting issues that are causing the two failing checks: PR #425010.
The second commit has the changes you need. Feel free to squash it into your PR. See farnoy@4b09641

Please use the review function. Opening such a PR is not only inconvenient but also narrows the scope of discussion. If you want, you can also open a new PR in nixpkgs.

I thought there was a way to propose changes to be merged via the review function as I've had people do that to my PRs before. That's what I was trying to do. In this case I was just trying to make it easy for the PR author to resolve the PR / Lint / treefmt failure.

farnoy · 2025-07-16T16:16:42Z

I've updated the MR @msgilligan @emaryn , it's still strictly additive (not removing any past versions), applying the autopatchelf override for 24 only, and with fixed formatting I hope. Should be mergeable in the current form 🤞

pkgs/development/compilers/graalvm/graalvm-oracle/default.nix

msgilligan

Changes LGTM. I built and installed on aarch64-darwin and did test builds of two Java projects.

I have one question though: Why "24" and not "24.0.2" which is the latest GraalVM Oracle build?

farnoy · 2025-07-16T17:45:45Z

Changes LGTM. I built and installed on aarch64-darwin and did test builds of two Java projects.

I have one question though: Why "24" and not "24.0.2" which is the latest GraalVM Oracle build?

Only the older releases have a stable archive download link, I believe. I see 24.0.1 in the archive

https://www.oracle.com/java/technologies/javase/graalvm-jdk24-archive-downloads.html

As of now, 24.0.2 is available here: https://www.oracle.com/java/technologies/downloads/?er=221886

But the full download link is not stable, they update it in place AFAIK https://download.oracle.com/java/24/latest/jdk-24_linux-x64_bin.tar.gz

farnoy · 2025-07-16T17:46:57Z

Huh, the 24.0.2 are available in the archive although they don't list them. I'll update to that version instead

msgilligan · 2025-07-16T18:17:10Z

BTW @farnoy I have started working on a Nixpkgs utility to report on versions and other metadata of all the JDKs in Nixpkgs, see Issue #425860.

msgilligan · 2025-08-03T01:52:11Z

I created a PR for graalvmPackages.graalvm-oracle_25-ea based on this PR :

PR graalvm-oracle_25-ea: init at 25-ea-32 #430508

nixos-discourse · 2025-08-12T20:41:38Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5759

msgilligan · 2025-08-13T21:25:34Z

@farnoy if you can make the change requested by SuperSandro2000 above, then I will run nixpkgs-review on aarch64-linux and aarch64-darwin.

farnoy · 2025-08-14T13:05:27Z

@msgilligan @SuperSandro2000 Should be good now

msgilligan · 2025-08-14T18:03:34Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 423224
Commit: 70116444439eb6e07b1db85f8e419a1bb3e1aa2f

`aarch64-linux`

✅ 1 package built:

graalvmPackages.graalvm-oracle (graalvmPackages.graalvm-oracle_24)

msgilligan · 2025-08-14T18:03:41Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 423224
Commit: 70116444439eb6e07b1db85f8e419a1bb3e1aa2f

`aarch64-darwin`

✅ 1 package built:

graalvmPackages.graalvm-oracle (graalvmPackages.graalvm-oracle_24)

msgilligan

Looks good. Tested with nixpkgs-review on aarch64-linux and aarch64-darwin

msgilligan · 2025-08-22T00:34:37Z

I've added a child PR to drop graalvm-oracle_23:

PR graalvm-oracle_23: drop #435723

msgilligan · 2025-08-22T00:40:53Z

@NixOS/java This needs review.

nix-owners bot requested review from ericdallo, bennyandresen, glittershark and hlolli July 7, 2025 14:39

nixpkgs-ci bot added 6.topic: java Including JDK, tooling, other languages, other VMs 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Jul 7, 2025

farnoy force-pushed the push-rpxnmuymkoty branch 2 times, most recently from b4f4396 to 8127dd3 Compare July 7, 2025 17:06

msgilligan reviewed Jul 13, 2025

View reviewed changes

msgilligan requested a review from a user July 13, 2025 22:57

msgilligan mentioned this pull request Jul 13, 2025

graalvm-oracle: 23.0.2 -> 24 #423088

Closed

13 tasks

ghost removed their request for review July 13, 2025 23:12

msgilligan mentioned this pull request Jul 13, 2025

Update Request: graalvm-oracle 23 -> 24 #423071

Open

3 tasks

msgilligan added a commit to msgilligan/nixpkgs that referenced this pull request Jul 14, 2025

graalvm-oracle_24: nix fmt

4b09641

Fix Nix formatting issue that is failing GitHub Actions checks. This should be squashed into PR NixOS#423224

msgilligan mentioned this pull request Jul 14, 2025

graalvm-oracle_24: PR 423224 nix fmt #425010

Closed

msgilligan mentioned this pull request Jul 14, 2025

graalvm-oracle_24: PR 423224 nix fmt farnoy/nixpkgs#1

Closed

farnoy force-pushed the push-rpxnmuymkoty branch from 8127dd3 to e7249f3 Compare July 16, 2025 16:15

farnoy commented Jul 16, 2025

View reviewed changes

pkgs/development/compilers/graalvm/graalvm-oracle/default.nix Outdated Show resolved Hide resolved

msgilligan approved these changes Jul 16, 2025

View reviewed changes

msgilligan self-requested a review July 16, 2025 16:54

nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 16, 2025

farnoy force-pushed the push-rpxnmuymkoty branch 2 times, most recently from 47e9c13 to 00d7959 Compare July 16, 2025 17:51

farnoy changed the title ~~graalvm-oracle_24: init at 24~~ graalvm-oracle_24: init at 24.0.2 Jul 16, 2025

msgilligan mentioned this pull request Aug 2, 2025

Java 25 Support Tracking Issue #430389

Open

msgilligan mentioned this pull request Aug 3, 2025

graalvm-oracle_25-ea: init at 25-ea-32 #430508

Merged

13 tasks

qzylinra mentioned this pull request Aug 12, 2025

Update Request: graalvmPackages.graalvm-oracle 23.0.1 → 24.0.1 #431341

Closed

3 tasks

farnoy force-pushed the push-rpxnmuymkoty branch from 00d7959 to 53ca5ed Compare August 14, 2025 13:00

graalvm-oracle_24: init at 24.0.2

7011644

farnoy force-pushed the push-rpxnmuymkoty branch from 53ca5ed to 7011644 Compare August 14, 2025 13:04

msgilligan requested review from SuperSandro2000 August 14, 2025 18:04

msgilligan approved these changes Aug 14, 2025

View reviewed changes

msgilligan requested review from Infinidoge and britter August 15, 2025 08:05

msgilligan mentioned this pull request Aug 22, 2025

graalvm-oracle_23: drop #435723

Merged

13 tasks

SuperSandro2000 approved these changes Aug 22, 2025

View reviewed changes

SuperSandro2000 merged commit 54e82f8 into NixOS:master Aug 22, 2025
27 of 28 checks passed

Uh oh!

graalvm-oracle_24: init at 24.0.2 #423224

graalvm-oracle_24: init at 24.0.2 #423224

Uh oh!

Conversation

farnoy commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Things done

Uh oh!

msgilligan commented Jul 13, 2025

Uh oh!

msgilligan left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

msgilligan Jul 13, 2025

Choose a reason for hiding this comment

Uh oh!

farnoy Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

msgilligan Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

msgilligan Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

msgilligan commented Jul 14, 2025

Uh oh!

msgilligan commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

farnoy commented Jul 16, 2025

Uh oh!

Uh oh!

msgilligan left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

farnoy commented Jul 16, 2025

Uh oh!

farnoy commented Jul 16, 2025

Uh oh!

msgilligan commented Jul 16, 2025

Uh oh!

msgilligan commented Aug 3, 2025

Uh oh!

nixos-discourse commented Aug 12, 2025

Uh oh!

msgilligan commented Aug 13, 2025

Uh oh!

farnoy commented Aug 14, 2025

Uh oh!

msgilligan commented Aug 14, 2025

nixpkgs-review result

aarch64-linux

Uh oh!

msgilligan commented Aug 14, 2025

nixpkgs-review result

aarch64-darwin

Uh oh!

msgilligan left a comment

Choose a reason for hiding this comment

Uh oh!

msgilligan commented Aug 22, 2025

Uh oh!

msgilligan commented Aug 22, 2025

Uh oh!

Uh oh!

Uh oh!

farnoy commented Jul 7, 2025 •

edited

Loading

msgilligan left a comment •

edited

Loading

msgilligan commented Jul 14, 2025 •

edited

Loading

msgilligan left a comment •

edited

Loading

`nixpkgs-review` result

`aarch64-linux`

`nixpkgs-review` result

`aarch64-darwin`