maplestory-cursor: init at 1.0.0 #423912
maplestory-cursor: init at 1.0.0 #423912
Conversation
There was a problem hiding this comment.
Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.
Note that this package could not have sufficient relevance.
How realistic is it that it will be used by other people? It's good that nixpkgs caters to various niches, but if it's a niche of 5 people it's probably too small. A good estimate is checking upstream issues and pull requests, or other software repositories. Library packages should have at least one dependent.
Checkout NUR for personal packages
| meta = with lib; { | ||
| description = "Maplestory Cursor"; | ||
| homepage = "https://github.com/Liam-Weitzel/maplestory-cursor"; | ||
| license = licenses.gpl3Plus; | ||
| maintainers = with maintainers; [ | ||
| liam-w | ||
| ]; | ||
| platforms = platforms.linux; | ||
| }; |
There was a problem hiding this comment.
| meta = with lib; { | |
| description = "Maplestory Cursor"; | |
| homepage = "https://github.com/Liam-Weitzel/maplestory-cursor"; | |
| license = licenses.gpl3Plus; | |
| maintainers = with maintainers; [ | |
| liam-w | |
| ]; | |
| platforms = platforms.linux; | |
| }; | |
| meta = { | |
| description = "Maplestory Cursor"; | |
| homepage = "https://github.com/Liam-Weitzel/maplestory-cursor"; | |
| license = lib.licenses.gpl3Plus; | |
| maintainers = with lib.maintainers; [ liam-w ]; | |
| platforms = lib.platforms.linux; | |
| }; |
| src = fetchFromGitHub { | ||
| owner = "Liam-Weitzel"; | ||
| repo = "maplestory-cursor"; | ||
| rev = "main"; |
There was a problem hiding this comment.
Use tagged version or full commit hash
| rev = "main"; | |
| rev = "ab043bdc2ee752141be89f6c4c4080c459d1243b"; |
|
|
||
| stdenvNoCC.mkDerivation (finalAttrs: { | ||
| pname = "maplestory-cursor"; | ||
| version = "1.0.0"; |
There was a problem hiding this comment.
Version not specified at all, use unstable versioning or assign a version in repo (version file, version as an attribute inside a file, as tag, ...)
| version = "1.0.0"; | |
| version = "0-unstable-2025-07-09"; |
maintainers/maintainer-list.nix
Outdated
| liam-w = { | ||
| email = "liam.weitzel2@gmail.com"; | ||
| github = "Liam-Weitzel"; | ||
| githubId = 22010764; | ||
| name = "Liam Weitzel"; | ||
| }; |
There was a problem hiding this comment.
Split into a separate commit. Use the following commit message: maintainers: add <name>
Note that this commit must precede the package commit
My first nix package, a maplestory inspired cursor theme developed on nixos + sway. Likely works on x11 too.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.