cibuildwheel: init at 3.1.3 #423815
Open
cibuildwheel: init at 3.1.3 #423815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
658f858 to
e66b5df
Compare
|
built wheels for a small sample project on x86_64 and aarch64, seems to work just fine (why wouldn't it, I guess) while this package could do with some small automated tests (possibly even running cibuildwheel's own integration tests), I don't really feel like digging into that right now - for now, I think this is ready to go! |
ghost
reviewed
Aug 8, 2025
d4b54a6 to
ea20223
Compare
|
updated to most recent upstream while I'm at it, sorry for all the force pushes - nixfmt+rebasing skill issue |
ea20223 to
0de2c9e
Compare
0de2c9e to
b4167f4
Compare
|
there's a bit of a funny happening here where the (freshly rebased onto) master has 928d755 but nixos-unstable has ac79170, meaning you can't actually apply this as-is using e.g. nixpkgs-patcher |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds cibuildwheel, a multi-platform multi-arch python wheel builder.
I've also gone ahead and added all required and optional dependencies that weren't in nixpkgs before, hope that's okay workflow-wise.
To actually use this in any meaningful way, you'll need docker/podman, but I don't see a reasonable way to enforce that dependency without a module for cibuildwheel, so I won't.
I was a bit surprised that nixpkgs didn't already have this because cibuildwheel seems like such a unique and relevant tool in the python space. I'm starting to have doubts about "fits contributing.md" + the minimum user rule and hope I'm not the only one (lol); let me know what you think.
(It's worth noting that people - including me until just now - could also have used a venv to install this tool)
I still want to do some more tests before this is ready to review/merge, I'm just creating the PR early to track that someone is working on this. (avoid someone else coincidentally doing the same thing)Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.