Skip to content

turborepo-remote-cache: init at 2.6.1 #423686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

turborepo-remote-cache: init at 2.6.1 #423686

wants to merge 2 commits into from

Conversation

humemm
Copy link
Contributor

@humemm humemm commented Jul 9, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf?
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
    • NixOS test(s)
    • package tests
    • lib/tests or pkgs/test
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
  • Tested basic functionality of all binary files (e.g. ./result/bin/turborepo-remote-cache --help and a basic cache round-trip)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

acid-bong
acid-bong suggested changes Jul 9, 2025
View reviewed changes
Copy link
Contributor

@acid-bong acid-bong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moin. A couple of notes, one is a must-have

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jul 9, 2025
@humemm humemm force-pushed the master branch 2 times, most recently from 85c355d to 4e0b183 Compare July 9, 2025 05:19
@acid-bong
Copy link
Contributor

Looks great so far (not commenting on Node-related stuff, cuz I'm not familiar with those). Welcome to the team and good luck nixing

@nixpkgs-ci nixpkgs-ci bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jul 9, 2025
@humemm humemm requested a review from acid-bong July 9, 2025 07:59
@humemm humemm force-pushed the master branch 3 times, most recently from 62f3449 to 26eaded Compare July 9, 2025 22:22
@humemm
Copy link
Contributor Author

humemm commented Jul 22, 2025 •
edited
Loading

@acid-bong, thanks for reviewing and helping out. What’s the next step to wrap this up?

@acid-bong
Copy link
Contributor

I posted the link here in a review request chat on Matrix, someone will come eventually

gepbird
gepbird reviewed Aug 3, 2025
View reviewed changes
gepbird
gepbird suggested changes Aug 4, 2025
View reviewed changes
Copy link
Contributor

@gepbird gepbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good at first, the package builds and runs, thanks for your contribution!

I listed some improvements below

@humemm humemm requested a review from gepbird August 11, 2025 19:16
@humemm humemm changed the title turborepo-remote-cache: init at 2.6.0 turborepo-remote-cache: init at 2.6.1 Aug 11, 2025
gepbird
gepbird reviewed Aug 11, 2025
View reviewed changes
gepbird
gepbird approved these changes Aug 12, 2025
View reviewed changes
Copy link
Contributor

@gepbird gepbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 12, 2025
@humemm
Copy link
Contributor Author

humemm commented Aug 12, 2025

updated to latest master, all suggestions are in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acid-bong acid-bong Awaiting requested review from acid-bong

1 more reviewer

@gepbird gepbird gepbird approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@humemm @acid-bong @gepbird