buildstream: 2.4.1 -> 2.5.0 #421920
Merged
buildstream: 2.4.1 -> 2.5.0 #421920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ef8c1b to
8d030b4
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5710 |
8d030b4 to
8fd215a
Compare
8fd215a to
5819389
Compare
|
Merge conflict resolved, ran |
5819389 to
b33d05b
Compare
b33d05b to
d024d32
Compare
|
Rebased against |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5713 |
d024d32 to
eb84e94
Compare
|
I don't think buildstream supports darwin, is there a way to skip those checks? |
|
@timbrown5 I've already specified |
|
It would be great to get this merged though. |
kragniz
reviewed
Aug 20, 2025
Applied two patches from upstream repository for Buildstrream, to fix the Protobuf runtime warnings, and dependency constraints. These patches can be removed once Buildstream v2.6.0 is released.
eb84e94 to
c0d7f1f
Compare
phaer
approved these changes
Aug 20, 2025
|
Successfully created backport PR for |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buildstream: 2.4.1 -> 2.5.0
Applied two patches from upstream repository for Buildstrream, to fix
the Protobuf runtime warnings, and dependency constraints.
These patches can be removed once Buildstream v2.6.0 is released.
For now, it is important to get 2.5.0 landed, as it includes a new API
which is necessary for new releases of Buildstream plugins.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.