typst-full: Typst environment with a full set of Typst packages #421686
Conversation
Defining it in a separate package directory is currently just for the CI thing --- as it requires a different way of versioning and a dedicated update script (maybe there's a better way to structure this tho). However, I would argue there are more benefits to provide a Also I would like to make |
…ot be found in the registry
| builtins.hashFile "sha256" ../typst/typst-packages-from-universe.toml | ||
| ); | ||
| typstFull = typst.withPackages (p: builtins.attrValues p); | ||
| updateTypstFull = writeShellScript "update-typst-full.sh" '' |
There was a problem hiding this comment.
Alright, fixed. Need to borrow some code from the common updater bc it requires hash to be defined in the nix file where this nix derivation doesn't have its own src/hash defined
| in | ||
| stdenv.mkDerivation (finalAttrs: { | ||
| pname = "typst-full"; | ||
| version = "${typst.version}.${packageSetVersion}"; |
There was a problem hiding this comment.
Fixed, mind letting me know why 0-unstable as a prefix?
|
Is there a way to override the attribute name from |
|
I don't quite understand the full reasoning for this PR.
But they are already evaled by Hydra, so I'm not quite sure what else this adds. Are you trying to have a package that represents the version of the Universe repo as a whole? I don't understand the point of that either though if so. No one really cares what the version of the Universe repo is. I can understand the value in a those lines and nothing else. |
Are they? Specifically I am talking about updating If the update script is integrated by Hydra, so far I didn't not see any automatic commit to update the meta file of Typst packages |
|
@RossSmyth @drupol Any followup? |
Things done
This PR adds a new package
typst-fullto instantiate a typst environment with a full set of Typst packages from Typst Universe.The main reason here to make it a separate package is to integrate typst packages update into nixpkgs CI and have a more or less meaningful version number to represent changes of the typst package set.
This PR is tested with
nix-shell maintainers/scripts/update.nix --argstr package typst-full --argstr commit true, and the update can be correctly committed on the current branch. However, based on the past experience, it doesn't necessarily implyr-ryantmwould correctly commit the update. Also please let me know if there's a better way to approach this.@emaryn @drupol
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.