-
-
Notifications
You must be signed in to change notification settings - Fork 16.5k
python3Packages: remove most --replace usages #420365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging
Are you sure you want to change the base?
Conversation
9ae2be4
to
62b4630
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through the diff and found nothing unexpected.
Assuming everything still builds fine, we should be able to merge this PR.
Thanks for doing this cleaning job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup, thanks for doing it!
To be honest this is a bit hard to review, can someone confirm if all of the "changed" packages build fine? Nix-Community builders can be used for this purpose. Another solution would be to split this into multiple chunks. |
I'll whip up a script with which you can test out the changes one by one, so as to avoid the many rebuilds. |
Tracking: #356002
This was made semi-manually.
I tried building all packages I changed while I was working on the PR, and I am fairly certain they'll build fine.
The methodology was:
--replace
with--replace-fail
in around ~10 packages.isDarwin
conditional.blivet
, I opted to use--replace-quiet
insteadpyu2f
I had to separate out asubstituteInPlace
into two partsHere's a script that only checks out the changes
to the file that the package is defined in and then builds it.
It takes a few hours to run and will generate a
failed.txt
file (which will hopefully be empty).Do note that some changes are behind optional flags, so this check is not 100% thorough.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.