Skip to content

Enable Virtualbox guest additions for AARCH64 #420556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 19, 2025
Merged

Enable Virtualbox guest additions for AARCH64 #420556

merged 2 commits into from
Aug 19, 2025

Conversation

ahbrosha
Copy link
Contributor

The virtualbox guest additions are supported on aarch64. This PR enables them and address #404735

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 12.first-time contribution This PR is the author's first one; please be gentle! 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jun 27, 2025
FriedrichAltheide
FriedrichAltheide reviewed Jul 16, 2025
View reviewed changes
FriedrichAltheide
FriedrichAltheide suggested changes Jul 17, 2025
View reviewed changes
@FriedrichAltheide
Copy link
Contributor

Thank you very much for the changes. I will test your PR on amd64 next week.

@FriedrichAltheide
Copy link
Contributor

Could you please squash your commits

@FriedrichAltheide
Copy link
Contributor

Please also have a look at the commit conventions: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#commit-conventions

Once, the commits are squashed and renamed according to the conventions I will approve this PR.

@ahbrosha
Copy link
Contributor Author

Please also have a look at the commit conventions: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#commit-conventions

Once, the commits are squashed and renamed according to the conventions I will approve this PR.

I refactored the commit messages, but organized them a little different. The first one enables the pkg to deal with aarch64, the second enables it in the module. Let me know if that's fine for you.

@FriedrichAltheide FriedrichAltheide added the backport release-25.05 Backport PR automatically label Aug 13, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Aug 13, 2025
@NetaliDev NetaliDev merged commit bc51535 into NixOS:master Aug 19, 2025
28 of 29 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Aug 19, 2025

Successfully created backport PR for release-25.05:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Aug 19, 2025
Open
1 task
@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Aug 19, 2025
@deftdawg deftdawg mentioned this pull request Aug 22, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NetaliDev NetaliDev NetaliDev approved these changes

@svanderburg svanderburg Awaiting requested review from svanderburg

+1 more reviewer

@FriedrichAltheide FriedrichAltheide FriedrichAltheide approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. 12.first-time contribution This PR is the author's first one; please be gentle! backport release-25.05 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahbrosha @FriedrichAltheide @NetaliDev