python313Packages.tensorpotential: init at 0.5.1 #420514
Conversation
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/python3packages-tensorpotential-reviewer-wanted/67044/1 |
|
@Sigmanificient, thank you for reviewing my PR. Upon your request to specify the dependencies, I noticed that one of them (matscipy) is missing in nixpkgs. I created another PR to contribute it (433184). Unfortunately I didn't get matscipy to build. I assume this PR would need to wait until 433184 is merged. Could you perhaps have a look at that PR as well? Also:
|
|
Remember next time that you can define multiple package in a single pr, as long as you keep them in separate commits, it is simpler to manage 😉 Here is an example on how to define a new license: 8d21ee7 |
lib/licenses.nix
Outdated
| fullName = "Academic Software License"; | ||
| url = "https://github.com/ACEsuit/ACE.jl/blob/main/ASL.md"; | ||
| }; | ||
|
|
There was a problem hiding this comment.
Given we already have asl20, I'm not sure calling a completely different license asl is a good idea…
There was a problem hiding this comment.
What do you think should be done about this?
There was a problem hiding this comment.
Also the licence is not FOSS and must be marked free = false; (it is not even redistributable AFAICT, since all the grants are conditional on non‐commercial use).
There was a problem hiding this comment.
Is it likely to be used for more than just this one package?
There was a problem hiding this comment.
Is it likely to be used for more than just this one package?
I am not sure, but I'd say the answer is more no than yes: the license is relatively recent and not widely adopted from what I see (even among scientific software).
There was a problem hiding this comment.
Then the simplest thing to do would be to just inline the license expression.
There was a problem hiding this comment.
@alyssais, could you be more specific on the necessary steps to include the license?
There was a problem hiding this comment.
Take the attribute set you're adding to licenses.nix, and use it directly as the value of meta.license in your package instead.
There was a problem hiding this comment.
Still needs to be marked non-free.
…nse to meta.license in tensorpotential
|
@alyssais thank you. I will squash everything together once it all works properly. :) |
I wish to contribute this scientific python library to Nixpkgs. It is a tool to generate machine-learned interatomic potentials. The derivation builds successfully on NixOS and nixpkgs 25.05.
Important:
The original license of the package (ASL, Academic Software License) is not present in
lib.licenses. It has been changed togpl2Onlyin my expression just to get it to evaluate, but this needs to be corrected.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.