-
-
Notifications
You must be signed in to change notification settings - Fork 16.6k
python3Packages.fastf1: init at 3.6.0 #418309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: emaryn <197520219+emaryn@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
implement @Sigmanificient's changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
implement @Sigmanificient 's changes
not sure why the code-review suggestions are not going through, i'm going to just add them manually |
Co-authored-by: Yohann Boniface <edhyjox@gmail.com>
Co-authored-by: Yohann Boniface <edhyjox@gmail.com>
Co-authored-by: Yohann Boniface <edhyjox@gmail.com>
Co-authored-by: Yohann Boniface <edhyjox@gmail.com>
the main issue/blocker for this PR right now is that we have to wait on the the pythonPackages.timple PR to be merged as:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all changes from code review resolved, see previous comment for current blockers
Add the Python library FastF1. From the library's README: FastF1 is a python package for accessing and analyzing Formula 1 results, schedules, timing data and telemetry.
As well, set myself as the maintainer for FastF1.
Of note: FastF1 depends on
python3Packages.timple
, which I have packaged in PR #418308.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.