Skip to content

Conversation

vaisriv
Copy link

@vaisriv vaisriv commented Jun 20, 2025

Add the Python library FastF1. From the library's README: FastF1 is a python package for accessing and analyzing Formula 1 results, schedules, timing data and telemetry.

As well, set myself as the maintainer for FastF1.

Of note: FastF1 depends on python3Packages.timple, which I have packaged in PR #418308.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested a review from natsukium June 20, 2025 02:28
@NixOSInfra NixOSInfra added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 20, 2025
Co-authored-by: emaryn <197520219+emaryn@users.noreply.github.com>
Copy link
Author

@vaisriv vaisriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implement @Sigmanificient's changes

Copy link
Author

@vaisriv vaisriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implement @Sigmanificient 's changes

@vaisriv
Copy link
Author

vaisriv commented Aug 8, 2025

implement @Sigmanificient 's changes

not sure why the code-review suggestions are not going through, i'm going to just add them manually

vaisriv and others added 2 commits August 8, 2025 14:59
Co-authored-by: Yohann Boniface <edhyjox@gmail.com>
Co-authored-by: Yohann Boniface <edhyjox@gmail.com>
vaisriv and others added 2 commits August 8, 2025 15:45
Co-authored-by: Yohann Boniface <edhyjox@gmail.com>
Co-authored-by: Yohann Boniface <edhyjox@gmail.com>
@vaisriv vaisriv changed the title python3Packages.fastf1: init at 3.5.3 python3Packages.fastf1: init at 3.6.0 Aug 8, 2025
@vaisriv
Copy link
Author

vaisriv commented Aug 8, 2025

the main issue/blocker for this PR right now is that we have to wait on the the pythonPackages.timple PR to be merged as:

  1. timple is a dependency of fastf1
  2. the timple pr contains the commit adding me to the maintainers list

Copy link
Author

@vaisriv vaisriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all changes from code review resolved, see previous comment for current blockers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
12.first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants