@HritwikSinghal: Sorry, my initial change just added the option, and not the config. That's fixed now, and dumplessUpgrade now defaults to true. If the user uses meilisearch for something else and has explicitly turned of dumplessUpgrades that's respected. (Could still surprise someone but I suppose that's unlikely.

If the user uses meilisearch for something else and has explicitly turned of dumplessUpgrades that's respected. (Could still surprise someone but I suppose that's unlikely.

i also think this is a better approach since karakeep doesn't officially support this method yet (they will when its out of experimental in meilisearch).

@HritwikSinghal: Sorry, my initial change just added the option, and not the config. That's fixed now, and dumplessUpgrade now defaults to true.

no worries :) , thanks for updating.

@tetov can we move ahead and merge this?

@HritwikSinghal https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#how-can-i-get-a-committer-to-look-at-my-pr

Edit: we need #412414 merged. I'll check if I posted this to the discourse thread when I get to a computer.

Rebased against master instead of basing on PR #412414, making this easier to review hopefully.

If you were previously replacing the module based on this PR you could use https://github.com/tetov/nixpkgs/tree/karakeep_combined_prs instead which includes #412414, #416531, #418146 & #426982.

fyi, its now services.meilisearch.settings.experimental_dumpless_upgrade. see https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/services/search/meilisearch.nix#L85C46-L85C75

@HritwikSinghal: rebase original commit and pushed another that changes the option name. Thanks for notifying me!

EDIT: Took me a while to figure out that the setting not only changed name but also moved to the freeform option settings..