Skip to content

ng-log: init 0.8.2 #418565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

ng-log: init 0.8.2 #418565

wants to merge 3 commits into from

Conversation

superherointj
Copy link
Contributor

@superherointj superherointj commented Jun 20, 2025 •
edited
Loading

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 20, 2025
@DieracDelta
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 418565
Commit: 087884e2d7aa9b4d38c0c29694fd5810382a5cdc

x86_64-linux

✅ 2 packages built:
  • ng-log
  • ng-log.dev

aarch64-linux

✅ 2 packages built:
  • ng-log
  • ng-log.dev

DieracDelta
DieracDelta approved these changes Jun 20, 2025
View reviewed changes
Copy link
Member

@DieracDelta DieracDelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, was able to build the two outputs. I haven't seen a maintainerless package merged into nixpkgs before...I guess this is common practice?

@github-actions github-actions bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 20, 2025
@superherointj
Copy link
Contributor Author

LGTM, was able to build the two outputs. I haven't seen a maintainerless package merged into nixpkgs before...I guess this is common practice?

Don't worry. I don't list myself as maintainer anymore for reasons. But I usually maintain packages.

@Aleksanaa
Copy link
Member

Don't worry. I don't list myself as maintainer anymore for reasons. But I usually maintain packages.

It's obvious that they didn't make a correct judgment. But please add yourself to the maintainers list first, otherwise you will never be notified

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jun 21, 2025
@superherointj superherointj marked this pull request as draft June 21, 2025 15:49
sikmir
sikmir reviewed Jun 21, 2025
View reviewed changes
@superherointj superherointj marked this pull request as ready for review August 5, 2025 12:07
@superherointj superherointj mentioned this pull request Aug 11, 2025
Merged
@superherointj superherointj changed the title ng-log: init 0.8.1 ng-log: init 0.8.2 Aug 16, 2025
@superherointj
Copy link
Contributor Author

Closing for lack of interest in such package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sikmir sikmir sikmir left review comments

+1 more reviewer

@DieracDelta DieracDelta DieracDelta approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@superherointj @DieracDelta @Aleksanaa @sikmir