Skip to content

nixos/sillytavern: add it #418452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

nixos/sillytavern: add it #418452

wants to merge 1 commit into from

Conversation

wrvsrx
Copy link
Contributor

@wrvsrx wrvsrx commented Jun 20, 2025 •
edited
Loading

Add sillytavern module.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@wrvsrx wrvsrx force-pushed the add-sillytavern-module branch from 68bf4a1 to 269dd76 Compare June 20, 2025 14:04
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: documentation This PR adds or changes documentation labels Jun 20, 2025
@wrvsrx wrvsrx force-pushed the add-sillytavern-module branch from 269dd76 to 4e2437e Compare June 21, 2025 05:36
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5592

awwpotato
awwpotato reviewed Jun 22, 2025
View reviewed changes
@wrvsrx wrvsrx force-pushed the add-sillytavern-module branch from 4e2437e to 99ecfa2 Compare June 24, 2025 08:21
@wrvsrx wrvsrx requested a review from awwpotato June 24, 2025 08:21
awwpotato
awwpotato reviewed Jun 26, 2025
View reviewed changes
Copy link
Contributor

@awwpotato awwpotato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also adding examples to the options would be good

@wrvsrx wrvsrx force-pushed the add-sillytavern-module branch from 99ecfa2 to ef93449 Compare June 28, 2025 04:49
@wrvsrx
Copy link
Contributor Author

wrvsrx commented Jun 28, 2025

also adding examples to the options would be good

Done. @awwpotato

@wrvsrx wrvsrx requested a review from awwpotato July 1, 2025 08:23
awwpotato
awwpotato suggested changes Jul 1, 2025
View reviewed changes
@wrvsrx wrvsrx force-pushed the add-sillytavern-module branch 2 times, most recently from f6c6d74 to f366ddf Compare July 1, 2025 18:36
@wrvsrx wrvsrx requested a review from awwpotato July 1, 2025 18:37
@A1ca7raz
Copy link
Member

A1ca7raz commented Jul 6, 2025

Add support for third-party extensions and extension manager:

in serviceConfig

BindPaths = [
    "${extensionDir}:${pkgs.sillytavern}/opt/sillytavern/public/scripts/extensions/third-party"
];

systemd.tmpfiles.rules = [ d '${extensionDir}' 0700 ${user} ${group} - -" ];

@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 7, 2025
@wrvsrx wrvsrx force-pushed the add-sillytavern-module branch from f366ddf to de51d7b Compare July 13, 2025 08:08
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 13, 2025
@wrvsrx wrvsrx force-pushed the add-sillytavern-module branch 2 times, most recently from 1c7830a to 72556dc Compare July 13, 2025 08:51
@wrvsrx wrvsrx requested a review from A1ca7raz July 13, 2025 08:54
A1ca7raz
A1ca7raz reviewed Jul 13, 2025
View reviewed changes
@wrvsrx wrvsrx force-pushed the add-sillytavern-module branch from 72556dc to 061bcf0 Compare July 13, 2025 09:19
@wrvsrx wrvsrx requested a review from A1ca7raz July 13, 2025 09:20
A1ca7raz
A1ca7raz reviewed Jul 13, 2025
View reviewed changes
@wrvsrx wrvsrx force-pushed the add-sillytavern-module branch from 061bcf0 to f587ccf Compare July 13, 2025 15:23
@wrvsrx wrvsrx requested a review from A1ca7raz July 13, 2025 15:23
A1ca7raz
A1ca7raz approved these changes Jul 13, 2025
View reviewed changes
Copy link
Member

@A1ca7raz A1ca7raz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 2.status: merge conflict This PR has merge conflicts with the target branch labels Jul 13, 2025
@wrvsrx wrvsrx force-pushed the add-sillytavern-module branch from f587ccf to 95b7ec3 Compare July 14, 2025 06:20
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 14, 2025
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5669

@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 19, 2025
@wrvsrx wrvsrx force-pushed the add-sillytavern-module branch from 95b7ec3 to 75c22fa Compare July 26, 2025 16:45
@wrvsrx
Copy link
Contributor Author

wrvsrx commented Jul 26, 2025

ping @awwpotato

@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 26, 2025
awwpotato
awwpotato approved these changes Jul 26, 2025
View reviewed changes
Copy link
Contributor

@awwpotato awwpotato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jul 26, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Jul 27, 2025
@rc-zb rc-zb mentioned this pull request Aug 10, 2025
Open
13 tasks
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
3 more reviewers

@A1ca7raz A1ca7raz A1ca7raz approved these changes

@Nyxvectar Nyxvectar Nyxvectar approved these changes

@awwpotato awwpotato awwpotato approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 3+ This PR was reviewed and approved by three or more persons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wrvsrx @nixos-discourse @A1ca7raz @Nyxvectar @awwpotato