Skip to content

foxglove-studio: init at 2.30.0 #417985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

foxglove-studio: init at 2.30.0 #417985

wants to merge 1 commit into from
+110 −0

Conversation

Sascha8a
Copy link
Contributor

Package for Foxglove Studio, a robotics visualization tool.

The package is straight forward, with some minor fixes to find libGL at runtime using a wrapper and a desktop entry, to open foxglove:// urls.

Note: This is based upon the great work in #366007 by @lennart-rth and #383690 by @jerry8137.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@Sascha8a Sascha8a requested a review from christoph-heiss June 18, 2025 22:48
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 18, 2025
acid-bong
acid-bong suggested changes Jun 19, 2025
View reviewed changes
acid-bong
acid-bong reviewed Jun 19, 2025
View reviewed changes
@Sascha8a Sascha8a force-pushed the init-foxglove-studio branch 2 times, most recently from e5d014f to 08b53a8 Compare June 19, 2025 11:08
@Sascha8a
Copy link
Contributor Author

Sascha8a commented Jun 19, 2025 •
edited
Loading

Thanks for the feedback @acid-bong. I have implemented your suggestions and force-pushed them.

acid-bong
acid-bong approved these changes Jun 19, 2025
View reviewed changes
Copy link
Contributor

@acid-bong acid-bong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good luck nixxing 🫡

@Sascha8a Sascha8a force-pushed the init-foxglove-studio branch from 08b53a8 to 2c5aad2 Compare June 19, 2025 11:11
@github-actions github-actions bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 19, 2025
@christoph-heiss
Copy link
Contributor

Note: This is based upon the great work in #366007 by @lennart-rth and #383690 by @jerry8137.

What about these PRs? There are still open.
Are they abandond? Should be closed an that case to properly indicate the effort shifted here.

christoph-heiss
christoph-heiss suggested changes Jun 19, 2025
View reviewed changes
@Sascha8a Sascha8a force-pushed the init-foxglove-studio branch from 2c5aad2 to 5740fce Compare June 19, 2025 14:13
@Sascha8a Sascha8a requested a review from christoph-heiss June 19, 2025 14:13
christoph-heiss
christoph-heiss suggested changes Jun 24, 2025
View reviewed changes
christoph-heiss
christoph-heiss reviewed Jun 25, 2025
View reviewed changes
@Sascha8a Sascha8a force-pushed the init-foxglove-studio branch from 5740fce to 171b6ac Compare June 25, 2025 08:13
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 25, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jun 25, 2025
@Sascha8a Sascha8a requested a review from kachick July 2, 2025 07:41
@christoph-heiss christoph-heiss requested a review from wegank July 2, 2025 18:44
kachick
kachick approved these changes Jul 3, 2025
View reviewed changes
Copy link
Member

@kachick kachick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with this tool or its dependencies. However, the diff and build result appear good to me.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Jul 3, 2025
@Sascha8a Sascha8a force-pushed the init-foxglove-studio branch from 171b6ac to 5ae4bec Compare July 6, 2025 19:10
@Sascha8a
Copy link
Contributor Author

Sascha8a commented Jul 6, 2025

Thank you for the feedback @kachick - greatly appreciated.

Sascha8a
Sascha8a commented Jul 9, 2025
View reviewed changes
Sascha8a
Sascha8a commented Jul 9, 2025
View reviewed changes
@Sascha8a Sascha8a force-pushed the init-foxglove-studio branch 2 times, most recently from bc662fb to 9b1d1f1 Compare July 9, 2025 20:41
@christoph-heiss
Copy link
Contributor

PR title also needs an update w.r.t the bump to 1.30.0.

@Sascha8a Sascha8a changed the title foxglove-studio: init at 2.29.1 foxglove-studio: init at 2.30.0 Jul 10, 2025
@Sascha8a Sascha8a force-pushed the init-foxglove-studio branch from 9b1d1f1 to 499c99a Compare July 10, 2025 16:33
christoph-heiss
christoph-heiss suggested changes Jul 14, 2025
View reviewed changes
@Sascha8a Sascha8a force-pushed the init-foxglove-studio branch from 499c99a to 20d0200 Compare July 16, 2025 14:16
@Sascha8a Sascha8a self-assigned this Jul 21, 2025
@Sascha8a
Copy link
Contributor Author

Is there a change we might get this merged @Aleksanaa or @misuzu? Thank you!

@Sascha8a
Copy link
Contributor Author

@NickCao could you maybe review and merge this? Would be greatly appreciated. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sigmanificient Sigmanificient Sigmanificient approved these changes

@Aleksanaa Aleksanaa Awaiting requested review from Aleksanaa

@misuzu misuzu Awaiting requested review from misuzu

@wegank wegank Awaiting requested review from wegank

@christoph-heiss christoph-heiss Awaiting requested review from christoph-heiss

@NickCao NickCao Awaiting requested review from NickCao

+2 more reviewers

@kachick kachick kachick approved these changes

@acid-bong acid-bong acid-bong approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Sascha8a Sascha8a

Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 3+ This PR was reviewed and approved by three or more persons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Sascha8a @christoph-heiss @kachick @NickCao @Sigmanificient @acid-bong