Skip to content

age-plugin-openpgp-card: init at 0.1.1 #417923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

age-plugin-openpgp-card: init at 0.1.1 #417923

wants to merge 1 commit into from

Conversation

nukdokplex
Copy link
Contributor

@nukdokplex nukdokplex commented Jun 18, 2025 •
edited
Loading

added age-plugin-openpgp-card package wiktor-k/age-plugin-openpgp-card

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Jun 18, 2025
@acid-bong
Copy link
Contributor

Do not merge in PRs, rebase instead

@nukdokplex nukdokplex force-pushed the age-plugin-openpgp-card branch from 5890806 to 7ac124a Compare June 24, 2025 01:01
@github-actions github-actions bot added 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. and removed 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Jun 24, 2025
@nukdokplex nukdokplex force-pushed the age-plugin-openpgp-card branch from 7ac124a to 61c568c Compare June 24, 2025 01:13
@nukdokplex nukdokplex marked this pull request as ready for review June 24, 2025 01:14
@nukdokplex
Copy link
Contributor Author

nukdokplex commented Jun 24, 2025 •
edited
Loading

i can't test is it running on other platforms, if anybody can please do it

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Jun 24, 2025
@nukdokplex nukdokplex self-assigned this Jun 24, 2025
avnik
avnik approved these changes Jun 24, 2025
View reviewed changes
Copy link
Contributor

@avnik avnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane and clean, it builds but need hardware to test if it works

@nukdokplex
Copy link
Contributor Author

Looks sane and clean, it builds but need hardware to test if it works

tested with real opgp card only on x86_64-linux, can't test on others due to lack of hardware

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 24, 2025
@nukdokplex nukdokplex requested a review from balsoft July 12, 2025 12:51
@nukdokplex nukdokplex force-pushed the age-plugin-openpgp-card branch from 61c568c to 1180988 Compare July 24, 2025 13:32
@nukdokplex nukdokplex removed the request for review from balsoft July 26, 2025 07:34
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5705

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5754

SuperSandro2000
SuperSandro2000 reviewed Aug 12, 2025
View reviewed changes
@nukdokplex nukdokplex force-pushed the age-plugin-openpgp-card branch from 1180988 to 64ac723 Compare August 13, 2025 14:02
@nukdokplex nukdokplex force-pushed the age-plugin-openpgp-card branch from 64ac723 to a8c3e0e Compare August 15, 2025 11:42
ViZiD
ViZiD approved these changes Aug 15, 2025
View reviewed changes
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@Qyriad Qyriad Awaiting requested review from Qyriad

2 more reviewers

@avnik avnik avnik approved these changes

@ViZiD ViZiD ViZiD approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@nukdokplex nukdokplex

Labels
10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nukdokplex @acid-bong @nixos-discourse @avnik @SuperSandro2000 @ViZiD