genai-toolbox: init at 0.10.0 #417565
Open
genai-toolbox: init at 0.10.0 #417565
+44
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The config file for the program gets specified like this: |
994b985 to
ab8344a
Compare
|
Iamanaws
reviewed
Jul 31, 2025
|
i will squash the commits later on |
hm weird, ill look into making it work on darwin |
7204aa9 to
ecd1d73
Compare
326da06 to
ecd1d73
Compare
ecd1d73 to
3dd8376
Compare
|
|
The program technically supports Darwin, but I currently do not have any devices available for testing. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5763 |
Iamanaws
reviewed
Aug 16, 2025
Comment on lines
+1
to
+6
| { | ||
| lib, | ||
| buildGoModule, | ||
| fetchFromGitHub, | ||
| versionCheckHook, | ||
| }: |
There was a problem hiding this comment.
Suggested change
| { | |
| lib, | |
| buildGoModule, | |
| fetchFromGitHub, | |
| versionCheckHook, | |
| }: | |
| { | |
| lib, | |
| buildGoModule, | |
| fetchFromGitHub, | |
| versionCheckHook, | |
| nix-update-script, | |
| }: |
Comment on lines
+32
to
+34
| nativeInstallCheckInputs = [ | ||
| versionCheckHook | ||
| ]; |
There was a problem hiding this comment.
Suggested change
| nativeInstallCheckInputs = [ | |
| versionCheckHook | |
| ]; | |
| nativeInstallCheckInputs = [ versionCheckHook ]; | |
| passthru = { updateScript = nix-update-script { }; }; |
There was a problem hiding this comment.
why should we add an empty update script?
Co-authored-by: Angel J <78835633+Iamanaws@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MCP Toolbox for Databases is an open source MCP server for databases. It enables you to develop mcp tools easier, faster, and more securely by handling the complexities such as connection pooling, authentication, and more.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.