python3Packages.django_5: 5.1 -> 5.2 #416022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
|
Too much was broken of the django ecosystem was broken on 5.2 the last time I tried this in #396590. |
|
The former is what the package is called on PyPI.
The former is what the package is called on PyPI.
The former is what the package is called on PyPI.
Hmm, my search didn't bring up that PR. Sorry! |
e603212 to
0d5b5c6
Compare
|
|
authentik doesn't yet work with django 5.2. Implementation is happening in goauthentik/authentik#14709 |
rissson
reviewed
Jun 12, 2025
That PR doesn't change any actual code. What indicates it doesn't work? |
It doesn't yet but the tests do indeed catch the error in the upstream project. The tests for authentik are probably disabled because they require postgres+redis to run. |
That's not a reason to disable tests. There could at least be a NixOS test but you can also use |
|
And |
13 tasks
|
Looked into the authentik-django tests a bit, but didn't get them running, but it's a start. Not going to continue working on them, nor will I submit them to nixpkgs like that. https://github.com/mweinelt/nixpkgs/pull/new/authentik-tests |
13 tasks
|
erictapen
approved these changes
Jun 13, 2025
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-25.05
git worktree add -d .worktree/backport-416022-to-release-25.05 origin/release-25.05
cd .worktree/backport-416022-to-release-25.05
git switch --create backport-416022-to-release-25.05
git cherry-pick -x 2fa44a6777ae30971f6f842882012d912df944d0 5d0bac880feb851703fc5460b0615e31f8a35c80 127252b5ed85c83416c6de760d97b00dd14cab8e 611b1e21e19b1c3fd452cb96c0491299b4ca4f0c f6f5cf8b93bf3da3baa4b017a44951b18ae55330 63acd590946323a19905a3ad428b49ac2d44b04b 58996511f655c52d5f6c3cb990ce32b55dfd9922 e1077a7e298425ff743d5b6d6e2af7a30386bc7b dcf15c53377212aea4151a02ade6266a633e48df 0d5b5c6213e27a50ce735bc12db29ef351148cc1 2f3a937a2e41e11dd91a29eaf18e2e9529b7dcde |
13 tasks
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.