You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages
Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
Tested basic functionality of all binary files (usually in ./result/bin/)
I'm also not an expert in this but my understanding is as follows: If something with this hash is present it will be used, no matter if the versions match. So you end up specifying a new version while still building the old one.
That's why something like versionCheckHook helps discover issues like this.
i encountered the same issue on my local machine when i upgraded my local vuetorrent pkg (i have a local one which use prebuild binary instead of building from source). I would update only the version field (which i see you did in this old commit). It should intuitively download the new binary and complain of hash mismatch, but would build without failing the hash.
i think replacing the hash with lib.fakeHash fixed it and it threw that error, thus i was able to get the correct hash. I don't remember now exactly how i fixed it
Edit: i can see you already fixed it. What was your solution?
Edit 2: nvm, lib.fakeHash was the solution for me.
@HritwikSinghal: I updated the hash based on my nix flake prefetch result and the pnpmDeps just by running it with lib.fakeHash. An empty (or just different) hash would have worked too.
I added update script (after checking that it could deal with pnpmDeps), and a testVersion. But that doesn't help much when the CLI reports the wrong version :(. Filed a bug report upstream.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.