Skip to content

tsduck: fix sporadic test failures on Darwin #416483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

tsduck: fix sporadic test failures on Darwin #416483

wants to merge 1 commit into from

Conversation

siriobalmelli
Copy link
Contributor

@siriobalmelli siriobalmelli commented Jun 13, 2025 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Closes #416484

Add a 👍 reaction to pull requests you find important.

@siriobalmelli
tsduck: fix sporadic test failures on Darwin
88ce367 
Signed-off-by: Sirio Balmelli <sirio@b-ad.ch>
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jun 13, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 13, 2025
@siriobalmelli siriobalmelli mentioned this pull request Jun 13, 2025
Open
3 tasks
@pbsds
Copy link
Member

pbsds commented Jun 17, 2025

tests seem to fail on linux

@siriobalmelli
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 416483

aarch64-linux

✅ 1 package built:
  • tsduck

@siriobalmelli
Copy link
Contributor Author

tests seem to fail on linux

They pass at this end. Please post the output of your failing build.

@pbsds
Copy link
Member

pbsds commented Jun 18, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 416483
Commit: 88ce367f705ea4c0ba4f7d66844cbce7f53b739d

x86_64-linux

✅ 1 package built:
  • tsduck

aarch64-linux

❌ 1 package failed to build:
  • tsduck

x86_64-darwin

✅ 1 package built:
  • tsduck

aarch64-darwin

✅ 1 package built:
  • tsduck
Error logs: `aarch64-linux`
tsduck 
condition: thread.start()

*** ThreadTest::DeleteWhenTerminated, assertion failure, utestThread.cpp, line 190

condition: thread->start()


*** ThreadTest::MutexTimeout, assertion failure, utestThread.cpp, line 258

condition: thread.start()


*** ThreadTest::Termination, assertion failure, utestThread.cpp, line 141

condition: thread.start()


*** TSProcessorTest::Processing, incorrect value, utestTSProcessor.cpp, line 230

expected: 5 ("5")

actual:   1 ("handler1.logs.size()")


*** FAILURES (6 tests FAILED, 643 passed, 6 assertions FAILED, 31807 passed)


make[2]: *** [Makefile:45: test-shared] Error 1

make[1]: *** [Makefile:42: test] Error 2

make: *** [Makefile:29: test] Error 2

@pbsds
Copy link
Member

pbsds commented Jun 18, 2025

seems to match the ofborg errors:

https://logs.ofborg.org/?key=nixos/nixpkgs.416483&attempt_id=9012182b-6955-4546-ad94-475a5f616918
https://logs.ofborg.org/?key=nixos/nixpkgs.416483&attempt_id=1a7b3b87-4ebf-4b26-8cb0-b47b8199c1ce

@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jul 4, 2025
@siriobalmelli siriobalmelli mentioned this pull request Aug 13, 2025
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tsduck: Build fail on aarch64 darwin due to localhost test
2 participants
@siriobalmelli @pbsds