command-not-found: migrate to pkgs/by-name #415070
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f7a9242 to
fec4fb0
Compare
drupol
reviewed
Jun 9, 2025
fec4fb0 to
d4c9d70
Compare
|
UPDATE: Added a comment in |
d4c9d70 to
7e9991f
Compare
drupol
reviewed
Jun 9, 2025
| perl, | ||
| dbPath ? null, | ||
| }: | ||
| replaceVarsWith rec { |
There was a problem hiding this comment.
Do you think we could get rid of rec and use let/in here?
There was a problem hiding this comment.
Sure!
By the way, the manual generation failed. nix-build ci -A manual-nixos --argstr system x86_64-linux
> error: attribute 'command-not-found' missing
> at /nix/store/rk8wb846907wjncg6fc2ns0rx2gwnzc7-nixos/modules/programs/command-not-found/command-not-found.nix:35:17:
> 34| dbPath = lib.mkOption {
> 35| default = pkgs.command-not-found.passthru.dbPath;
> | ^
> 36| description = ''
> Cacheable portion of option doc build failed.
> Usually this means that an option attribute that ends up in documentation (eg `default` or `description`) depends on the restricted module arguments `config` or `pkgs`.
>
> Rebuild your configuration with `--show-trace` to find the offending location. Remove the references to restricted arguments (eg by escaping their antiquotations or adding a `defaultText`) or disable the sandboxed build for the failing module by setting `meta.buildDocsInSandbox = false`.
There was a problem hiding this comment.
Perhaps my idea to use passthru.dbPath was not the best, better ask on Matrix about it?
7e9991f to
dbf73f0
Compare
13 tasks
- Migrated command-not-found to pkgs/by-name - Introduced the `programs.command-not-found.package` option to allow users to override the default package
dbf73f0 to
c5111a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
programs.command-not-found.packageoptionto allow users to override the default package
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.