-
-
Notifications
You must be signed in to change notification settings - Fork 16.6k
bazaar: init at 0.4.0 #415884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
bazaar: init at 0.4.0 #415884
Conversation
537bc53
to
21d19f9
Compare
fbdedbd
to
cf06225
Compare
Not ready yet because still alpha software. |
Worked with the dev a bit to iron out some issues that seemed nixos-specific, and they released |
Some initial nits:
diff --git a/pkgs/by-name/ba/bazaar/package.nix b/pkgs/by-name/ba/bazaar/package.nix
index c9d0c11bc8b7..dae59029c219 100644
--- a/pkgs/by-name/ba/bazaar/package.nix
+++ b/pkgs/by-name/ba/bazaar/package.nix
@@ -64,10 +64,18 @@ stdenv.mkDerivation (finalAttrs: {
src = fetchFromGitHub {
owner = "kolunmi";
repo = "bazaar";
- rev = "v${finalAttrs.version}";
+ tag = "v${finalAttrs.version}";
hash = "sha256-QzzWj6KjyKNMBHQ/RqvUSL6QeokgvK2Fc+23kkt3SMM=";
};
+ nativeBuildInputs = [
+ desktop-file-utils
+ meson
+ ninja
+ pkg-config
+ wrapGAppsHook4
+ ];
+
buildInputs = [
appstream
flatpak
@@ -88,14 +96,6 @@ stdenv.mkDerivation (finalAttrs: {
libyaml
];
- nativeBuildInputs = [
- desktop-file-utils
- meson
- ninja
- pkg-config
- wrapGAppsHook4
- ];
-
mesonFlags = [
(lib.mesonOption "hardcoded_content_config_path" "${finalAttrs.passthru.configFile}")
];
|
never mind the patch is for libglycin |
From a design perspective it should either be absent/not visible (ideal) or they would be a specific message saying that there is no configuration/curation provided (less ideal). Re: my comment about branding: I don't have an idea of what Nix branding might look like since NixOS is a general purpose DIY distribution. There could maybe exist a general purpose configuration upstream that can just be used if the distribution doesn't wish to curate anything specific because it looks like the config takes hardcoded flatpak refs instead of being sorted by tags. I remember seeing mockups for a trending page in the GNOME design matrix but I don't see that there from your screenshot. |
I've drafted a upstream issue for this to see what approach we should take. |
Had to update libdex also. PR search is broken for me right now, so for testing purposes in the same PR. |
suggestion: remove libdex commit The libdex version bump no longer needs to be included, most apps aren't using this new of a libdex version as it isn't in the GNOME 48 SDK kolunmi/bazaar@2e243a5 thought: Curated section issue resolved This issue was resolved in kolunmi/bazaar@f19feae so we don't have to worry about a default configuration in the next major version. |
Alright I think I can do that if I up the package to 0.3.1. |
Nope, I still get |
That change seems to have been reverted in https://github.com/kolunmi/bazaar/commits/a7504afb8fbe960577346e9ea55b5bed227003b7 |
I guess we're waiting for an upstream change like kolunmi/bazaar#214 ? Or do I just override the src and version for libdex in |
Image loading still broken...... |
Fixes #415342.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.