Skip to content

nixos_render_docs: fix weird rendered UTF-8 arrows to ASCII ones #415845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

nixos_render_docs: fix weird rendered UTF-8 arrows to ASCII ones #415845

wants to merge 1 commit into from

Conversation

SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Jun 11, 2025 •
edited
Loading

I have Wezterm and Nerdfonts and even with that the arrows render pretty strange.

image

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@SuperSandro2000
nixos_render_docs: fix weird rendered UTF-8 arrows to ASCII ones
e5a8519 
I have Wezterm and Nerdfonts and even with that the arrows render pretty
strange.
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 11, 2025
GetPsyched
GetPsyched approved these changes Jun 11, 2025
View reviewed changes
Copy link
Member

@GetPsyched GetPsyched left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly don't remember why I used these.
cc. @fricklerhandwerk

@fricklerhandwerk
Copy link
Contributor

The chevrons (angle brackets, not arrows) are typographically correct though (not the HTML less-than >) and are widely used in technical literature to signify parameters. Also it's decidedly distinct from any computer language syntax elements. And it renders exactly as expected. The spacing looks slightly weird but that's due to the monospace font, this is unavoidable.

I'm not gonna die on that hill, but there's no strong technical reason for this change.

@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. 12.approvals: 2 This PR was reviewed and approved by two persons. labels Jun 11, 2025
@SuperSandro2000
Copy link
Member Author

They look like this in a terminal where monospaces is usually used. If you get that error message you are first thinking that some escape characters messed everything up and broke something in a really weird way.

image

@fricklerhandwerk
Copy link
Contributor

Well that's the font rendering them on the right half of the character cell for some reason. I don't know; we don't have a policy for using UTF-8. There are some codes that are essentially equivalent in meaning, maybe those have wider/better support among fonts? One could also argue to stay compatible with 1980s terminals for... reasons, but I'd prefer these reasons to be explicit.

@nixpkgs-ci nixpkgs-ci bot removed the 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. label Jun 24, 2025
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aleksanaa Aleksanaa Aleksanaa approved these changes

@hsjobeki hsjobeki Awaiting requested review from hsjobeki

@fricklerhandwerk fricklerhandwerk Awaiting requested review from fricklerhandwerk

+1 more reviewer

@GetPsyched GetPsyched GetPsyched approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SuperSandro2000 @fricklerhandwerk @Aleksanaa @GetPsyched @wegank