nixos/stage-1: respect X-mount.subdir option #414391
Conversation
There was a problem hiding this comment.
Can we just.... always use util-linux mount? It's arguably always good to delegate to the mount helper, and to support the X-mount.* options that only util-linux supports. The only concern is if that grows the size of the initrd by an intolerable amount but I strongly suspect it'll only be a few kilobytes so we should just do it.
And yea while we're at it we should just move the mount.zfs part into the ZFS module.
|
I had that thought too, both changes sound good to me but will double check the size to make sure. |
6f3ced8 to
1007970
Compare
|
Yeah it's only 12kB, made it unconditional. The ZFS module now includes mount.zfs either in extraUtilsCommands or systemd.extraBin. Also I noticed zdb doesn't get added with boot.initrd.systemd, is that an oversight? |
- respect X-mount.subdir option - fix mount test redirection (1>&1 to 2>&1)
1007970 to
47a31c3
Compare
|
This has been working for me on two bcachefs on root machines with subvolumes. |
Updates stage-1.nix to make enabling util-linux's mount possible for multiple reasons, like the existing ZFS mount helper use case and the new X-mount.subdir use case.
Resolves #414390
Add a 👍 reaction to pull requests you find important.