-
-
Notifications
You must be signed in to change notification settings - Fork 16.6k
netbox_4_3: init at 4.3.2 #414367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
netbox_4_3: init at 4.3.2 #414367
Conversation
3232117
to
3e72348
Compare
pyproject = true; | ||
|
||
src = fetchFromGitHub { | ||
owner = "strawberry-graphql"; | ||
repo = "strawberry-django"; | ||
tag = "v${version}"; | ||
hash = "sha256-nwqb9AVNQNIRdjYcutTaI3YfwuMDLP4mUirSXFq+WnI="; | ||
hash = "sha256-mMI/tPdt9XK6Lz7VmI3uDxcCjIuidUeGHjG+6AQLoeQ="; | ||
}; | ||
|
||
build-system = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you ask upstream to remove setuptools from this? Or is it really needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll look into it.
3e72348
to
128f623
Compare
669c307
to
2ec508b
Compare
2ec508b
to
0af0be6
Compare
0af0be6
to
d3721ed
Compare
d3721ed
to
e8eb187
Compare
e8eb187
to
10237aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Can you mark NetBox 4.2 as EOL? Same as here:
nixpkgs/pkgs/by-name/ne/netbox_4_1/package.nix
Lines 130 to 132 in 7a2c2ff
knownVulnerabilities = [ | |
"Netbox version ${version} is EOL; please upgrade by following the current release notes instructions." | |
]; |
Some plugins fail to build, I think because of a wrong disabled
attribute. You should be able to replace it like so:
- disabled = pythonAtLeast "3.13";
+ disabled = python.pythonVersion != netbox.python.pythonVersion;
After that, I think this PR just needs a rebase to fix the merge conflict.
nixpkgs-review
result
Generated using nixpkgs-review
.
Command: nixpkgs-review pr 414367
Commit: 10237aa70c98f09f66d3bd9dc23fe6bf413a4fc4
x86_64-linux
⏩ 1 package marked as broken and skipped:
- netbox_4_1
⏩ 2 packages blacklisted:
- nixos-install-tools
- tests.nixos-functions.nixos-test
❌ 10 packages failed to build:
- python312Packages.netbox-attachments
- python312Packages.netbox-attachments.dist
- python312Packages.netbox-contract
- python312Packages.netbox-contract.dist
- python312Packages.netbox-floorplan-plugin
- python312Packages.netbox-floorplan-plugin.dist
- python312Packages.netbox-napalm-plugin
- python312Packages.netbox-napalm-plugin.dist
- python312Packages.netbox-topology-views
- python312Packages.netbox-topology-views.dist
✅ 39 packages built:
- netbox (netbox_4_3)
- netbox_4_2
- nixpkgs-manual
- python312Packages.netbox-bgp
- python312Packages.netbox-bgp.dist
- python312Packages.netbox-documents
- python312Packages.netbox-documents.dist
- python312Packages.netbox-interface-synchronization
- python312Packages.netbox-interface-synchronization.dist
- python312Packages.netbox-plugin-prometheus-sd
- python312Packages.netbox-plugin-prometheus-sd.dist
- python312Packages.netbox-qrcode
- python312Packages.netbox-qrcode.dist
- python312Packages.netbox-reorder-rack
- python312Packages.netbox-reorder-rack.dist
- python312Packages.netbox-routing
- python312Packages.netbox-routing.dist
- python312Packages.strawberry-django
- python312Packages.strawberry-django.dist
- python312Packages.strawberry-graphql
- python312Packages.strawberry-graphql.dist
- python313Packages.netbox-bgp
- python313Packages.netbox-bgp.dist
- python313Packages.netbox-documents
- python313Packages.netbox-documents.dist
- python313Packages.netbox-interface-synchronization
- python313Packages.netbox-interface-synchronization.dist
- python313Packages.netbox-plugin-prometheus-sd
- python313Packages.netbox-plugin-prometheus-sd.dist
- python313Packages.netbox-qrcode
- python313Packages.netbox-qrcode.dist
- python313Packages.netbox-reorder-rack
- python313Packages.netbox-reorder-rack.dist
- python313Packages.netbox-routing
- python313Packages.netbox-routing.dist
- python313Packages.strawberry-django
- python313Packages.strawberry-django.dist
- python313Packages.strawberry-graphql
- python313Packages.strawberry-graphql.dist
Error logs: `x86_64-linux`
python312Packages.netbox-attachments
@nix { "action": "setPhase", "phase": "pythonImportsCheckPhase" } Executing pythonImportsCheckPhase Check whether the following modules can be imported: netbox_attachments Traceback (most recent call last): File "", line 1, in File "", line 1, in File "/nix/store/89laaz8x9pdydxzz74p0vd8vdj0szqbq-python3-3.12.11/lib/python3.12/importlib/__init__.py", line 90, in import_module return _bootstrap._gcd_import(name[level:], package, level) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "", line 1387, in _gcd_import File "", line 1360, in _find_and_load File "", line 1331, in _find_and_load_unlocked File "", line 935, in _load_unlocked File "", line 999, in exec_module File "", line 488, in _call_with_frames_removed File "/nix/store/ncc1nxg8hixwkvvf75dzpdz2vgvaag2m-python3.12-netbox-attachments-7.2.0/lib/python3.12/site-packages/netbox_attachments/__init__.py", line 1, in from netbox.plugins import PluginConfig File "/nix/store/prhfcmf1nn58xs152fwcxkxs6biv5pgc-netbox-4.3.2/opt/netbox/netbox/netbox/plugins/__init__.py", line 4, in from django.apps import AppConfig ModuleNotFoundError: No module named 'django'
python312Packages.netbox-contract
Check whether the following modules can be imported: netbox_contract Traceback (most recent call last): File "", line 1, in File "", line 1, in File "/nix/store/89laaz8x9pdydxzz74p0vd8vdj0szqbq-python3-3.12.11/lib/python3.12/importlib/__init__.py", line 90, in import_module return _bootstrap._gcd_import(name[level:], package, level) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "", line 1387, in _gcd_import File "", line 1360, in _find_and_load File "", line 1331, in _find_and_load_unlocked File "", line 935, in _load_unlocked File "", line 999, in exec_module File "", line 488, in _call_with_frames_removed File "/nix/store/gxahcxhzwipwaf136g2zb9vqsxhdp5zz-python3.12-netbox-contract-2.3.2/lib/python3.12/site-packages/netbox_contract/__init__.py", line 1, in from netbox.plugins import PluginConfig File "/nix/store/prhfcmf1nn58xs152fwcxkxs6biv5pgc-netbox-4.3.2/opt/netbox/netbox/netbox/plugins/__init__.py", line 11, in from netbox.search import register_search File "/nix/store/prhfcmf1nn58xs152fwcxkxs6biv5pgc-netbox-4.3.2/opt/netbox/netbox/netbox/search/__init__.py", line 6, in from netaddr import IPAddress, IPNetwork ModuleNotFoundError: No module named 'netaddr'
python312Packages.netbox-floorplan-plugin
@nix { "action": "setPhase", "phase": "pythonImportsCheckPhase" } Executing pythonImportsCheckPhase Check whether the following modules can be imported: netbox_floorplan Traceback (most recent call last): File "", line 1, in File "", line 1, in File "/nix/store/89laaz8x9pdydxzz74p0vd8vdj0szqbq-python3-3.12.11/lib/python3.12/importlib/__init__.py", line 90, in import_module return _bootstrap._gcd_import(name[level:], package, level) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "", line 1387, in _gcd_import File "", line 1360, in _find_and_load File "", line 1331, in _find_and_load_unlocked File "", line 935, in _load_unlocked File "", line 999, in exec_module File "", line 488, in _call_with_frames_removed File "/nix/store/zc5pgk39lz5d14a0wfvw72vj9w1201l2-python3.12-netbox-floorplan-plugin-0.6.0/lib/python3.12/site-packages/netbox_floorplan/__init__.py", line 1, in from netbox.plugins import PluginConfig File "/nix/store/prhfcmf1nn58xs152fwcxkxs6biv5pgc-netbox-4.3.2/opt/netbox/netbox/netbox/plugins/__init__.py", line 4, in from django.apps import AppConfig ModuleNotFoundError: No module named 'django'
python312Packages.netbox-napalm-plugin
@nix { "action": "setPhase", "phase": "pythonImportsCheckPhase" } Executing pythonImportsCheckPhase Check whether the following modules can be imported: netbox_napalm_plugin Traceback (most recent call last): File "", line 1, in File "", line 1, in File "/nix/store/89laaz8x9pdydxzz74p0vd8vdj0szqbq-python3-3.12.11/lib/python3.12/importlib/__init__.py", line 90, in import_module return _bootstrap._gcd_import(name[level:], package, level) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "", line 1387, in _gcd_import File "", line 1360, in _find_and_load File "", line 1331, in _find_and_load_unlocked File "", line 935, in _load_unlocked File "", line 999, in exec_module File "", line 488, in _call_with_frames_removed File "/nix/store/4cjs4c8p9jrax036q1mgkd0hzzdfz949-python3.12-netbox-napalm-plugin-0.3.1/lib/python3.12/site-packages/netbox_napalm_plugin/__init__.py", line 8, in from netbox.plugins import PluginConfig File "/nix/store/prhfcmf1nn58xs152fwcxkxs6biv5pgc-netbox-4.3.2/opt/netbox/netbox/netbox/plugins/__init__.py", line 4, in from django.apps import AppConfig ModuleNotFoundError: No module named 'django'
python312Packages.netbox-topology-views
@nix { "action": "setPhase", "phase": "pythonImportsCheckPhase" } Executing pythonImportsCheckPhase Check whether the following modules can be imported: netbox_topology_views Traceback (most recent call last): File "", line 1, in File "", line 1, in File "/nix/store/89laaz8x9pdydxzz74p0vd8vdj0szqbq-python3-3.12.11/lib/python3.12/importlib/__init__.py", line 90, in import_module return _bootstrap._gcd_import(name[level:], package, level) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "", line 1387, in _gcd_import File "", line 1360, in _find_and_load File "", line 1331, in _find_and_load_unlocked File "", line 935, in _load_unlocked File "", line 999, in exec_module File "", line 488, in _call_with_frames_removed File "/nix/store/lqglh0z7viwgfqpf0jvkf468wvr7a8yi-python3.12-netbox-topology-views-4.2.1/lib/python3.12/site-packages/netbox_topology_views/__init__.py", line 1, in from netbox.plugins import PluginConfig File "/nix/store/prhfcmf1nn58xs152fwcxkxs6biv5pgc-netbox-4.3.2/opt/netbox/netbox/netbox/plugins/__init__.py", line 4, in from django.apps import AppConfig ModuleNotFoundError: No module named 'django'
10237aa
to
4bfb13e
Compare
|
lgtm for netbox-floorplan-plugin. Thank you for integrating the update into this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks a lot!
Only one final rebase needed, someone edited the plugins a few hours ago…
nixpkgs-review
result
Generated using nixpkgs-review
.
Command: nixpkgs-review pr 414367
Commit: 4bfb13e0f4043757ca517ed276aa56f6983c3e5a
x86_64-linux
⏩ 2 packages marked as broken and skipped:
- netbox_4_1
- netbox_4_2
⏩ 2 packages blacklisted:
- nixos-install-tools
- tests.nixos-functions.nixos-test
✅ 48 packages built:
- netbox (netbox_4_3)
- nixpkgs-manual
- python312Packages.netbox-bgp
- python312Packages.netbox-bgp.dist
- python312Packages.netbox-documents
- python312Packages.netbox-documents.dist
- python312Packages.netbox-interface-synchronization
- python312Packages.netbox-interface-synchronization.dist
- python312Packages.netbox-plugin-prometheus-sd
- python312Packages.netbox-plugin-prometheus-sd.dist
- python312Packages.netbox-qrcode
- python312Packages.netbox-qrcode.dist
- python312Packages.netbox-reorder-rack
- python312Packages.netbox-reorder-rack.dist
- python312Packages.netbox-routing
- python312Packages.netbox-routing.dist
- python312Packages.strawberry-django
- python312Packages.strawberry-django.dist
- python312Packages.strawberry-graphql
- python312Packages.strawberry-graphql.dist
- python313Packages.netbox-attachments
- python313Packages.netbox-attachments.dist
- python313Packages.netbox-bgp
- python313Packages.netbox-bgp.dist
- python313Packages.netbox-contract
- python313Packages.netbox-contract.dist
- python313Packages.netbox-documents
- python313Packages.netbox-documents.dist
- python313Packages.netbox-floorplan-plugin
- python313Packages.netbox-floorplan-plugin.dist
- python313Packages.netbox-interface-synchronization
- python313Packages.netbox-interface-synchronization.dist
- python313Packages.netbox-napalm-plugin
- python313Packages.netbox-napalm-plugin.dist
- python313Packages.netbox-plugin-prometheus-sd
- python313Packages.netbox-plugin-prometheus-sd.dist
- python313Packages.netbox-qrcode
- python313Packages.netbox-qrcode.dist
- python313Packages.netbox-reorder-rack
- python313Packages.netbox-reorder-rack.dist
- python313Packages.netbox-routing
- python313Packages.netbox-routing.dist
- python313Packages.netbox-topology-views
- python313Packages.netbox-topology-views.dist
- python313Packages.strawberry-django
- python313Packages.strawberry-django.dist
- python313Packages.strawberry-graphql
- python313Packages.strawberry-graphql.dist
4bfb13e
to
a861a2d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! @leona-ya can you update your review? Apparently I can't merge if a member has a "Request changes" review.
nixpkgs-review
result
Generated using nixpkgs-review
.
Command: nixpkgs-review pr 414367
Commit: a861a2d60ec593936873b99c97b0270910db19dc
x86_64-linux
⏩ 2 packages marked as broken and skipped:
- netbox_4_1
- netbox_4_2
⏩ 2 packages blacklisted:
- nixos-install-tools
- tests.nixos-functions.nixos-test
✅ 48 packages built:
- netbox (netbox_4_3)
- nixpkgs-manual
- python312Packages.netbox-bgp
- python312Packages.netbox-bgp.dist
- python312Packages.netbox-documents
- python312Packages.netbox-documents.dist
- python312Packages.netbox-interface-synchronization
- python312Packages.netbox-interface-synchronization.dist
- python312Packages.netbox-plugin-prometheus-sd
- python312Packages.netbox-plugin-prometheus-sd.dist
- python312Packages.netbox-qrcode
- python312Packages.netbox-qrcode.dist
- python312Packages.netbox-reorder-rack
- python312Packages.netbox-reorder-rack.dist
- python312Packages.netbox-routing
- python312Packages.netbox-routing.dist
- python312Packages.strawberry-django
- python312Packages.strawberry-django.dist
- python312Packages.strawberry-graphql
- python312Packages.strawberry-graphql.dist
- python313Packages.netbox-attachments
- python313Packages.netbox-attachments.dist
- python313Packages.netbox-bgp
- python313Packages.netbox-bgp.dist
- python313Packages.netbox-contract
- python313Packages.netbox-contract.dist
- python313Packages.netbox-documents
- python313Packages.netbox-documents.dist
- python313Packages.netbox-floorplan-plugin
- python313Packages.netbox-floorplan-plugin.dist
- python313Packages.netbox-interface-synchronization
- python313Packages.netbox-interface-synchronization.dist
- python313Packages.netbox-napalm-plugin
- python313Packages.netbox-napalm-plugin.dist
- python313Packages.netbox-plugin-prometheus-sd
- python313Packages.netbox-plugin-prometheus-sd.dist
- python313Packages.netbox-qrcode
- python313Packages.netbox-qrcode.dist
- python313Packages.netbox-reorder-rack
- python313Packages.netbox-reorder-rack.dist
- python313Packages.netbox-routing
- python313Packages.netbox-routing.dist
- python313Packages.netbox-topology-views
- python313Packages.netbox-topology-views.dist
- python313Packages.strawberry-django
- python313Packages.strawberry-django.dist
- python313Packages.strawberry-graphql
- python313Packages.strawberry-graphql.dist
For the future, there is a “Dismiss review” button in the merge box near my review |
Nice to know, thanks! |
Things done
netbox_4_3
packagestrawberry-graphql
andstrawberry-django
netbox_4_3
netbox_3_7
upgrade test, apparently a left-over from NetBox: 4.2.7 -> 4.2.9 + cleanup #401110Attempting to continue this from #405880 (comment)
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.