Skip to content

Conversation

transcaffeine
Copy link
Contributor

@transcaffeine transcaffeine commented Jun 5, 2025

Things done

  • Add netbox_4_3 package
    • Update python dependencies strawberry-graphql and strawberry-django
  • Adjust nixos (upgrade) tests for netbox_4_3
  • drop the netbox_3_7 upgrade test, apparently a left-over from NetBox: 4.2.7 -> 4.2.9 + cleanup #401110

Attempting to continue this from #405880 (comment)

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS labels Jun 5, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jun 5, 2025
pyproject = true;

src = fetchFromGitHub {
owner = "strawberry-graphql";
repo = "strawberry-django";
tag = "v${version}";
hash = "sha256-nwqb9AVNQNIRdjYcutTaI3YfwuMDLP4mUirSXFq+WnI=";
hash = "sha256-mMI/tPdt9XK6Lz7VmI3uDxcCjIuidUeGHjG+6AQLoeQ=";
};

build-system = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you ask upstream to remove setuptools from this? Or is it really needed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll look into it.

@github-actions github-actions bot added 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: documentation This PR adds or changes documentation labels Jun 5, 2025
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 5, 2025
@transcaffeine transcaffeine force-pushed the netbox/4.3.2 branch 2 times, most recently from 669c307 to 2ec508b Compare June 6, 2025 15:52
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 6, 2025
@transcaffeine transcaffeine marked this pull request as ready for review June 7, 2025 09:38
@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jun 7, 2025
@nix-owners nix-owners bot requested review from Izorkin and minijackson June 7, 2025 19:23
@github-actions github-actions bot removed the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jun 20, 2025
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 22, 2025
Copy link
Member

@minijackson minijackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Can you mark NetBox 4.2 as EOL? Same as here:

knownVulnerabilities = [
"Netbox version ${version} is EOL; please upgrade by following the current release notes instructions."
];

Some plugins fail to build, I think because of a wrong disabled attribute. You should be able to replace it like so:

-  disabled = pythonAtLeast "3.13";
+  disabled = python.pythonVersion != netbox.python.pythonVersion;

After that, I think this PR just needs a rebase to fix the merge conflict.


nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 414367
Commit: 10237aa70c98f09f66d3bd9dc23fe6bf413a4fc4


x86_64-linux

⏩ 1 package marked as broken and skipped:
  • netbox_4_1
⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
❌ 10 packages failed to build:
  • python312Packages.netbox-attachments
  • python312Packages.netbox-attachments.dist
  • python312Packages.netbox-contract
  • python312Packages.netbox-contract.dist
  • python312Packages.netbox-floorplan-plugin
  • python312Packages.netbox-floorplan-plugin.dist
  • python312Packages.netbox-napalm-plugin
  • python312Packages.netbox-napalm-plugin.dist
  • python312Packages.netbox-topology-views
  • python312Packages.netbox-topology-views.dist
✅ 39 packages built:
  • netbox (netbox_4_3)
  • netbox_4_2
  • nixpkgs-manual
  • python312Packages.netbox-bgp
  • python312Packages.netbox-bgp.dist
  • python312Packages.netbox-documents
  • python312Packages.netbox-documents.dist
  • python312Packages.netbox-interface-synchronization
  • python312Packages.netbox-interface-synchronization.dist
  • python312Packages.netbox-plugin-prometheus-sd
  • python312Packages.netbox-plugin-prometheus-sd.dist
  • python312Packages.netbox-qrcode
  • python312Packages.netbox-qrcode.dist
  • python312Packages.netbox-reorder-rack
  • python312Packages.netbox-reorder-rack.dist
  • python312Packages.netbox-routing
  • python312Packages.netbox-routing.dist
  • python312Packages.strawberry-django
  • python312Packages.strawberry-django.dist
  • python312Packages.strawberry-graphql
  • python312Packages.strawberry-graphql.dist
  • python313Packages.netbox-bgp
  • python313Packages.netbox-bgp.dist
  • python313Packages.netbox-documents
  • python313Packages.netbox-documents.dist
  • python313Packages.netbox-interface-synchronization
  • python313Packages.netbox-interface-synchronization.dist
  • python313Packages.netbox-plugin-prometheus-sd
  • python313Packages.netbox-plugin-prometheus-sd.dist
  • python313Packages.netbox-qrcode
  • python313Packages.netbox-qrcode.dist
  • python313Packages.netbox-reorder-rack
  • python313Packages.netbox-reorder-rack.dist
  • python313Packages.netbox-routing
  • python313Packages.netbox-routing.dist
  • python313Packages.strawberry-django
  • python313Packages.strawberry-django.dist
  • python313Packages.strawberry-graphql
  • python313Packages.strawberry-graphql.dist

Error logs: `x86_64-linux`
python312Packages.netbox-attachments
@nix { "action": "setPhase", "phase": "pythonImportsCheckPhase" }
Executing pythonImportsCheckPhase
Check whether the following modules can be imported: netbox_attachments
Traceback (most recent call last):
  File "", line 1, in 
  File "", line 1, in 
  File "/nix/store/89laaz8x9pdydxzz74p0vd8vdj0szqbq-python3-3.12.11/lib/python3.12/importlib/__init__.py", line 90, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "", line 1387, in _gcd_import
  File "", line 1360, in _find_and_load
  File "", line 1331, in _find_and_load_unlocked
  File "", line 935, in _load_unlocked
  File "", line 999, in exec_module
  File "", line 488, in _call_with_frames_removed
  File "/nix/store/ncc1nxg8hixwkvvf75dzpdz2vgvaag2m-python3.12-netbox-attachments-7.2.0/lib/python3.12/site-packages/netbox_attachments/__init__.py", line 1, in 
    from netbox.plugins import PluginConfig
  File "/nix/store/prhfcmf1nn58xs152fwcxkxs6biv5pgc-netbox-4.3.2/opt/netbox/netbox/netbox/plugins/__init__.py", line 4, in 
    from django.apps import AppConfig
ModuleNotFoundError: No module named 'django'
python312Packages.netbox-contract
Check whether the following modules can be imported: netbox_contract
Traceback (most recent call last):
  File "", line 1, in 
  File "", line 1, in 
  File "/nix/store/89laaz8x9pdydxzz74p0vd8vdj0szqbq-python3-3.12.11/lib/python3.12/importlib/__init__.py", line 90, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "", line 1387, in _gcd_import
  File "", line 1360, in _find_and_load
  File "", line 1331, in _find_and_load_unlocked
  File "", line 935, in _load_unlocked
  File "", line 999, in exec_module
  File "", line 488, in _call_with_frames_removed
  File "/nix/store/gxahcxhzwipwaf136g2zb9vqsxhdp5zz-python3.12-netbox-contract-2.3.2/lib/python3.12/site-packages/netbox_contract/__init__.py", line 1, in 
    from netbox.plugins import PluginConfig
  File "/nix/store/prhfcmf1nn58xs152fwcxkxs6biv5pgc-netbox-4.3.2/opt/netbox/netbox/netbox/plugins/__init__.py", line 11, in 
    from netbox.search import register_search
  File "/nix/store/prhfcmf1nn58xs152fwcxkxs6biv5pgc-netbox-4.3.2/opt/netbox/netbox/netbox/search/__init__.py", line 6, in 
    from netaddr import IPAddress, IPNetwork
ModuleNotFoundError: No module named 'netaddr'
python312Packages.netbox-floorplan-plugin
@nix { "action": "setPhase", "phase": "pythonImportsCheckPhase" }
Executing pythonImportsCheckPhase
Check whether the following modules can be imported: netbox_floorplan
Traceback (most recent call last):
  File "", line 1, in 
  File "", line 1, in 
  File "/nix/store/89laaz8x9pdydxzz74p0vd8vdj0szqbq-python3-3.12.11/lib/python3.12/importlib/__init__.py", line 90, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "", line 1387, in _gcd_import
  File "", line 1360, in _find_and_load
  File "", line 1331, in _find_and_load_unlocked
  File "", line 935, in _load_unlocked
  File "", line 999, in exec_module
  File "", line 488, in _call_with_frames_removed
  File "/nix/store/zc5pgk39lz5d14a0wfvw72vj9w1201l2-python3.12-netbox-floorplan-plugin-0.6.0/lib/python3.12/site-packages/netbox_floorplan/__init__.py", line 1, in 
    from netbox.plugins import PluginConfig
  File "/nix/store/prhfcmf1nn58xs152fwcxkxs6biv5pgc-netbox-4.3.2/opt/netbox/netbox/netbox/plugins/__init__.py", line 4, in 
    from django.apps import AppConfig
ModuleNotFoundError: No module named 'django'
python312Packages.netbox-napalm-plugin
@nix { "action": "setPhase", "phase": "pythonImportsCheckPhase" }
Executing pythonImportsCheckPhase
Check whether the following modules can be imported: netbox_napalm_plugin
Traceback (most recent call last):
  File "", line 1, in 
  File "", line 1, in 
  File "/nix/store/89laaz8x9pdydxzz74p0vd8vdj0szqbq-python3-3.12.11/lib/python3.12/importlib/__init__.py", line 90, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "", line 1387, in _gcd_import
  File "", line 1360, in _find_and_load
  File "", line 1331, in _find_and_load_unlocked
  File "", line 935, in _load_unlocked
  File "", line 999, in exec_module
  File "", line 488, in _call_with_frames_removed
  File "/nix/store/4cjs4c8p9jrax036q1mgkd0hzzdfz949-python3.12-netbox-napalm-plugin-0.3.1/lib/python3.12/site-packages/netbox_napalm_plugin/__init__.py", line 8, in 
    from netbox.plugins import PluginConfig
  File "/nix/store/prhfcmf1nn58xs152fwcxkxs6biv5pgc-netbox-4.3.2/opt/netbox/netbox/netbox/plugins/__init__.py", line 4, in 
    from django.apps import AppConfig
ModuleNotFoundError: No module named 'django'
python312Packages.netbox-topology-views
@nix { "action": "setPhase", "phase": "pythonImportsCheckPhase" }
Executing pythonImportsCheckPhase
Check whether the following modules can be imported: netbox_topology_views
Traceback (most recent call last):
  File "", line 1, in 
  File "", line 1, in 
  File "/nix/store/89laaz8x9pdydxzz74p0vd8vdj0szqbq-python3-3.12.11/lib/python3.12/importlib/__init__.py", line 90, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "", line 1387, in _gcd_import
  File "", line 1360, in _find_and_load
  File "", line 1331, in _find_and_load_unlocked
  File "", line 935, in _load_unlocked
  File "", line 999, in exec_module
  File "", line 488, in _call_with_frames_removed
  File "/nix/store/lqglh0z7viwgfqpf0jvkf468wvr7a8yi-python3.12-netbox-topology-views-4.2.1/lib/python3.12/site-packages/netbox_topology_views/__init__.py", line 1, in 
    from netbox.plugins import PluginConfig
  File "/nix/store/prhfcmf1nn58xs152fwcxkxs6biv5pgc-netbox-4.3.2/opt/netbox/netbox/netbox/plugins/__init__.py", line 4, in 
    from django.apps import AppConfig
ModuleNotFoundError: No module named 'django'

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 23, 2025
@nix-owners nix-owners bot requested a review from RaitoBezarius June 23, 2025 21:18
@transcaffeine
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 414367
Commit: 4bfb13e0f4043757ca517ed276aa56f6983c3e5a


x86_64-linux

⏩ 1 package blacklisted:
  • nixos-install-tools
✅ 48 packages built:
  • netbox
  • nixpkgs-manual
  • python312Packages.netbox-bgp
  • python312Packages.netbox-bgp.dist
  • python312Packages.netbox-documents
  • python312Packages.netbox-documents.dist
  • python312Packages.netbox-interface-synchronization
  • python312Packages.netbox-interface-synchronization.dist
  • python312Packages.netbox-plugin-prometheus-sd
  • python312Packages.netbox-plugin-prometheus-sd.dist
  • python312Packages.netbox-qrcode
  • python312Packages.netbox-qrcode.dist
  • python312Packages.netbox-reorder-rack
  • python312Packages.netbox-reorder-rack.dist
  • python312Packages.netbox-routing
  • python312Packages.netbox-routing.dist
  • python312Packages.strawberry-django
  • python312Packages.strawberry-django.dist
  • python312Packages.strawberry-graphql
  • python312Packages.strawberry-graphql.dist
  • python313Packages.netbox-attachments
  • python313Packages.netbox-attachments.dist
  • python313Packages.netbox-bgp
  • python313Packages.netbox-bgp.dist
  • python313Packages.netbox-contract
  • python313Packages.netbox-contract.dist
  • python313Packages.netbox-documents
  • python313Packages.netbox-documents.dist
  • python313Packages.netbox-floorplan-plugin
  • python313Packages.netbox-floorplan-plugin.dist
  • python313Packages.netbox-interface-synchronization
  • python313Packages.netbox-interface-synchronization.dist
  • python313Packages.netbox-napalm-plugin
  • python313Packages.netbox-napalm-plugin.dist
  • python313Packages.netbox-plugin-prometheus-sd
  • python313Packages.netbox-plugin-prometheus-sd.dist
  • python313Packages.netbox-qrcode
  • python313Packages.netbox-qrcode.dist
  • python313Packages.netbox-reorder-rack
  • python313Packages.netbox-reorder-rack.dist
  • python313Packages.netbox-routing
  • python313Packages.netbox-routing.dist
  • python313Packages.netbox-topology-views
  • python313Packages.netbox-topology-views.dist
  • python313Packages.strawberry-django
  • python313Packages.strawberry-django.dist
  • python313Packages.strawberry-graphql
  • python313Packages.strawberry-graphql.dist

@Chaostheorie
Copy link
Contributor

lgtm for netbox-floorplan-plugin. Thank you for integrating the update into this PR.

Copy link
Member

@minijackson minijackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks a lot!

Only one final rebase needed, someone edited the plugins a few hours ago…


nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 414367
Commit: 4bfb13e0f4043757ca517ed276aa56f6983c3e5a


x86_64-linux

⏩ 2 packages marked as broken and skipped:
  • netbox_4_1
  • netbox_4_2
⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 48 packages built:
  • netbox (netbox_4_3)
  • nixpkgs-manual
  • python312Packages.netbox-bgp
  • python312Packages.netbox-bgp.dist
  • python312Packages.netbox-documents
  • python312Packages.netbox-documents.dist
  • python312Packages.netbox-interface-synchronization
  • python312Packages.netbox-interface-synchronization.dist
  • python312Packages.netbox-plugin-prometheus-sd
  • python312Packages.netbox-plugin-prometheus-sd.dist
  • python312Packages.netbox-qrcode
  • python312Packages.netbox-qrcode.dist
  • python312Packages.netbox-reorder-rack
  • python312Packages.netbox-reorder-rack.dist
  • python312Packages.netbox-routing
  • python312Packages.netbox-routing.dist
  • python312Packages.strawberry-django
  • python312Packages.strawberry-django.dist
  • python312Packages.strawberry-graphql
  • python312Packages.strawberry-graphql.dist
  • python313Packages.netbox-attachments
  • python313Packages.netbox-attachments.dist
  • python313Packages.netbox-bgp
  • python313Packages.netbox-bgp.dist
  • python313Packages.netbox-contract
  • python313Packages.netbox-contract.dist
  • python313Packages.netbox-documents
  • python313Packages.netbox-documents.dist
  • python313Packages.netbox-floorplan-plugin
  • python313Packages.netbox-floorplan-plugin.dist
  • python313Packages.netbox-interface-synchronization
  • python313Packages.netbox-interface-synchronization.dist
  • python313Packages.netbox-napalm-plugin
  • python313Packages.netbox-napalm-plugin.dist
  • python313Packages.netbox-plugin-prometheus-sd
  • python313Packages.netbox-plugin-prometheus-sd.dist
  • python313Packages.netbox-qrcode
  • python313Packages.netbox-qrcode.dist
  • python313Packages.netbox-reorder-rack
  • python313Packages.netbox-reorder-rack.dist
  • python313Packages.netbox-routing
  • python313Packages.netbox-routing.dist
  • python313Packages.netbox-topology-views
  • python313Packages.netbox-topology-views.dist
  • python313Packages.strawberry-django
  • python313Packages.strawberry-django.dist
  • python313Packages.strawberry-graphql
  • python313Packages.strawberry-graphql.dist

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jun 24, 2025
Copy link
Member

@minijackson minijackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! @leona-ya can you update your review? Apparently I can't merge if a member has a "Request changes" review.


nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 414367
Commit: a861a2d60ec593936873b99c97b0270910db19dc


x86_64-linux

⏩ 2 packages marked as broken and skipped:
  • netbox_4_1
  • netbox_4_2
⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 48 packages built:
  • netbox (netbox_4_3)
  • nixpkgs-manual
  • python312Packages.netbox-bgp
  • python312Packages.netbox-bgp.dist
  • python312Packages.netbox-documents
  • python312Packages.netbox-documents.dist
  • python312Packages.netbox-interface-synchronization
  • python312Packages.netbox-interface-synchronization.dist
  • python312Packages.netbox-plugin-prometheus-sd
  • python312Packages.netbox-plugin-prometheus-sd.dist
  • python312Packages.netbox-qrcode
  • python312Packages.netbox-qrcode.dist
  • python312Packages.netbox-reorder-rack
  • python312Packages.netbox-reorder-rack.dist
  • python312Packages.netbox-routing
  • python312Packages.netbox-routing.dist
  • python312Packages.strawberry-django
  • python312Packages.strawberry-django.dist
  • python312Packages.strawberry-graphql
  • python312Packages.strawberry-graphql.dist
  • python313Packages.netbox-attachments
  • python313Packages.netbox-attachments.dist
  • python313Packages.netbox-bgp
  • python313Packages.netbox-bgp.dist
  • python313Packages.netbox-contract
  • python313Packages.netbox-contract.dist
  • python313Packages.netbox-documents
  • python313Packages.netbox-documents.dist
  • python313Packages.netbox-floorplan-plugin
  • python313Packages.netbox-floorplan-plugin.dist
  • python313Packages.netbox-interface-synchronization
  • python313Packages.netbox-interface-synchronization.dist
  • python313Packages.netbox-napalm-plugin
  • python313Packages.netbox-napalm-plugin.dist
  • python313Packages.netbox-plugin-prometheus-sd
  • python313Packages.netbox-plugin-prometheus-sd.dist
  • python313Packages.netbox-qrcode
  • python313Packages.netbox-qrcode.dist
  • python313Packages.netbox-reorder-rack
  • python313Packages.netbox-reorder-rack.dist
  • python313Packages.netbox-routing
  • python313Packages.netbox-routing.dist
  • python313Packages.netbox-topology-views
  • python313Packages.netbox-topology-views.dist
  • python313Packages.strawberry-django
  • python313Packages.strawberry-django.dist
  • python313Packages.strawberry-graphql
  • python313Packages.strawberry-graphql.dist

@leona-ya
Copy link
Member

For the future, there is a “Dismiss review” button in the merge box near my review

@leona-ya leona-ya merged commit a467ed2 into NixOS:master Jun 25, 2025
23 checks passed
@minijackson
Copy link
Member

Nice to know, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python Python is a high-level, general-purpose programming language. 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants