Skip to content

nixos/newt: init #414337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2025
Merged

nixos/newt: init #414337

merged 1 commit into from
Jul 18, 2025

Conversation

jackrosenberg
Copy link
Member

@jackrosenberg jackrosenberg commented Jun 5, 2025 •
edited
Loading

Init of a systemd service to run newt-go. Newt is a fully user space WireGuard tunnel client and TCP/UDP proxy, designed to securely expose private resources controlled by Pangolin.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Jun 5, 2025
@NixOSInfra NixOSInfra added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 5, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 5, 2025
SigmaSquadron
SigmaSquadron reviewed Jun 6, 2025
View reviewed changes
Copy link
Contributor

@SigmaSquadron SigmaSquadron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@jackrosenberg jackrosenberg force-pushed the master branch 2 times, most recently from 5d0b19e to cbd951c Compare June 6, 2025 10:45
@SigmaSquadron SigmaSquadron self-assigned this Jun 6, 2025
@jackrosenberg jackrosenberg changed the title Init services/newt nixos/newt: init Jun 6, 2025
@h7x4 h7x4 added the 8.has: module (new) This PR adds a module in `nixos/` label Jun 9, 2025
SigmaSquadron
SigmaSquadron reviewed Jun 9, 2025
View reviewed changes
@SigmaSquadron
Copy link
Contributor

SigmaSquadron commented Jun 9, 2025 •
edited
Loading

I'd also recommend giving the descriptions and assertion messages another pass. Pangolin and Newt must be capitalised, and users need to know what an option does by looking at their description and nothing else.

@jackrosenberg jackrosenberg force-pushed the master branch 2 times, most recently from 98d03f0 to 0fed149 Compare June 10, 2025 12:38
@github-actions github-actions bot removed the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jun 10, 2025
jackrosenberg

This comment was marked as resolved.

Sign in to view

@jackrosenberg jackrosenberg requested a review from Aleksanaa June 13, 2025 14:03
SigmaSquadron
SigmaSquadron reviewed Jun 14, 2025
View reviewed changes
@jackrosenberg jackrosenberg force-pushed the master branch 2 times, most recently from 19add99 to b0ace22 Compare June 14, 2025 22:30
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 14, 2025
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 14, 2025
@github-actions github-actions bot added 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation labels Jun 14, 2025
@jackrosenberg jackrosenberg mentioned this pull request Jun 15, 2025
Draft
13 tasks
@jackrosenberg jackrosenberg force-pushed the master branch 2 times, most recently from dcf397d to b2dd07d Compare June 22, 2025 15:19
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 22, 2025
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 22, 2025
@jackrosenberg jackrosenberg force-pushed the master branch 2 times, most recently from 6e68286 to c00747b Compare June 23, 2025 14:44
@github-actions github-actions bot removed the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 23, 2025
@github-actions github-actions bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 23, 2025
SigmaSquadron
SigmaSquadron requested changes Jun 24, 2025
View reviewed changes
@jackrosenberg jackrosenberg force-pushed the master branch 2 times, most recently from b17d791 to 9e27a29 Compare June 27, 2025 12:54
SigmaSquadron
SigmaSquadron reviewed Jun 27, 2025
View reviewed changes
SigmaSquadron
SigmaSquadron reviewed Jun 27, 2025
View reviewed changes
SigmaSquadron
SigmaSquadron reviewed Jun 28, 2025
View reviewed changes
SuperSandro2000
SuperSandro2000 reviewed Jun 30, 2025
View reviewed changes
SigmaSquadron
SigmaSquadron requested changes Jul 9, 2025
View reviewed changes
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2448

@Aleksanaa Aleksanaa merged commit 03b3a97 into NixOS:master Jul 18, 2025
25 of 27 checks passed
@jackrosenberg jackrosenberg mentioned this pull request Jul 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SigmaSquadron SigmaSquadron SigmaSquadron requested changes

@Aleksanaa Aleksanaa Awaiting requested review from Aleksanaa

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees

@SigmaSquadron SigmaSquadron

Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jackrosenberg @SigmaSquadron @nixos-discourse @SuperSandro2000 @h7x4 @Aleksanaa @NixOSInfra