fosrl-pangolin: init at 1.2.0 #414976
fosrl-pangolin: init at 1.2.0 #414976
Conversation
28ee33d to
5182ed3
Compare
|
5182ed3 to
72b40c7
Compare
4b26f2e to
65cfc48
Compare
65cfc48 to
a67b82e
Compare
a67b82e to
4a41640
Compare
7f84793 to
1e41d25
Compare
|
| npmDepsHash = "sha256-fi4e79Bk1LC/LizBJ+EhCjDzLR5ZocgVyWbSXsEJKdw="; | ||
| nativeBuildInputs = [ esbuild ]; | ||
| # fix the dependency on google fonts | ||
| patches = [ ./dep.patch ]; |
There was a problem hiding this comment.
If this patch is fixing something (from its description), perhaps it should be upstreamed ?
There was a problem hiding this comment.
the patch removes the single call to :import { Figtree, Inter } from "next/font/google";
which for some reason is downloaded from google itself during the build
There was a problem hiding this comment.
as far as I can tell the font isn't actually used anywhere, so yea, will definitely add to my list of questions for upstream!
There was a problem hiding this comment.
Perhaps then creating the pull request upstream would be a better idea, then use the patch url instead ?
There was a problem hiding this comment.
could do that i think, is there an advantage to that over using nix patches?
There was a problem hiding this comment.
If I remember correctly this is the preferred way to have a patch in nixpkgs. I think it's in the contributing guide.
There was a problem hiding this comment.
Fixed this up by using google fonts like in the upstream, but with substituteInPlace and localfont so i dont need to update the patch. based on: https://github.com/NixOS/nixpkgs/blob/f7bf574774e466b984063a44330384cdbca67d6c/pkgs/by-name/ne/nextjs-ollama-llm-ui/package.nix
ba977fb to
b73053b
Compare
c146ba6 to
2ae1049
Compare
2ae1049 to
cc39a38
Compare
Package for Pangolin, a self-hosted tunneled reverse proxy server with identity and access control, designed to securely expose private resources on distributed networks. Service to come soon :)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.