Skip to content

umap: init at 3.0.6 #413335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

umap: init at 3.0.6 #413335

wants to merge 4 commits into from

Conversation

LorenzBischof
Copy link
Contributor

@LorenzBischof LorenzBischof commented Jun 2, 2025 •
edited by wolfgangwalther
Loading

Things done

This adds https://umap-project.org/. Currently not tested and the frontend is still missing.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@LorenzBischof LorenzBischof marked this pull request as draft June 2, 2025 19:31
@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Jun 2, 2025
@nix-owners nix-owners bot requested a review from natsukium June 2, 2025 19:32
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 2, 2025
@jcollie
Copy link
Contributor

jcollie commented Aug 1, 2025

Thanks for getting this package started. I tried using this to move my current docker-based umap installation over to NixOS and I had to make the following changes to get the ASGI service working under uvicorn.

diff --git a/pkgs/by-name/um/umap/package.nix b/pkgs/by-name/um/umap/package.nix
index 330147888f42..f21c3a37b815 100644
--- a/pkgs/by-name/um/umap/package.nix
+++ b/pkgs/by-name/um/umap/package.nix
@@ -2,6 +2,7 @@
   lib,
   python3,
   fetchFromGitHub,
+  umap,
 }:
 let
   python = python3.override {
@@ -35,13 +36,18 @@ python.pkgs.buildPythonApplication rec {
     django-agnocomplete
     django-environ
     django-probes
+    django-storages
     pillow
     psycopg
+    pydantic
     rcssmin
+    redis
     requests
     rjsmin
+    six
     social-auth-app-django
     social-auth-core
+    websockets
   ];

   pythonRelaxDeps = [
@@ -86,6 +92,10 @@ python.pkgs.buildPythonApplication rec {
   #    ];
   #  };

+  passthru = {
+    pythonPath = "${umap}/${python.sitePackages}:${python.pkgs.makePythonPath dependencies}";
+  };
+
   meta = {
     description = "UMap lets you create maps with OpenStreetMap layers in a minute and embed them in your site";
     homepage = "https://github.com/umap-project/umap/";

With those changes, I was able to use the following to start umap up as a systemd service:

export PYTHONPATH=${pkgs.umap.pythonPath}
${lib.getExe pkgs.python3Packages.uvicorn} --proxy-headers --host ::1 --port 3111 umap.asgi:application

@anoadragon453 anoadragon453 mentioned this pull request Aug 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natsukium natsukium Awaiting requested review from natsukium

Assignees
No one assigned
Labels
6.topic: python Python is a high-level, general-purpose programming language. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LorenzBischof @jcollie