Skip to content

ocamlPackages.xenstore: 2.3.0 -> 2.4.0 #413745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

ocamlPackages.xenstore: 2.3.0 -> 2.4.0 #413745

wants to merge 2 commits into from

Conversation

momeemt
Copy link
Member

@momeemt momeemt commented Jun 3, 2025 •
edited
Loading

nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD" threw some errors by mirage-crypto-rng, but it shouldn't be related to updating this package except ocamlPackages.xenstore-tool.

--------- Report for 'aarch64-darwin' ---------
4 packages failed to build:
ocamlPackages.conduit-mirage ocamlPackages.gluten-mirage ocamlPackages.irmin-mirage-git ocamlPackages.xenstore-tool

7 packages built:
ocamlPackages.mirage-bootvar-xen ocamlPackages.mirage-net-xen ocamlPackages.mirage-xen ocamlPackages.netchannel ocamlPackages.vchan ocamlPackages.xenstore ocamlPackages.xenstore_transport

Diff: https://github.com/mirage/ocaml-xenstore@v2.3.0...2.4.0
Changelog: https://github.com/mirage/ocaml-xenstore/releases/tag/2.4.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 6.topic: xen-project Issues and PRs related to the Xen Project Hypervisor. labels Jun 3, 2025
@nix-owners nix-owners bot requested a review from ulrikstrid June 3, 2025 23:20
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 3, 2025
@momeemt momeemt marked this pull request as draft June 3, 2025 23:24
@momeemt
Copy link
Member Author

momeemt commented Jun 3, 2025

@ulrikstrid Hello, can I have a question? This update (xenstore 2.4.0) removes deprecated function restrict, but ocamlPackages.xenstore-tool is depends on it. I feel that applying the patch will be difficult because it involves a fundamental change. Would maintaining different versions of xenstore to resolve this issue? If not, would you suggest another solution? Unfortunately, ocamlPackages.xenstore-tool doesn't accept issues.

@psafont
Copy link

psafont commented Jul 18, 2025

nfortunately, ocamlPackages.xenstore-tool doesn't accept issues.

Sorry about that, I've enabled Issues for it. I'm puzzled regarding the incompatibility, xapi uses both libraries and haven't found an issues with it. Maybe it's because xentool cli is not used directly?

@last-genius
Copy link

@ulrikstrid Hello, can I have a question? This update (xenstore 2.4.0) removes deprecated function restrict, but ocamlPackages.xenstore-tool is depends on it. I feel that applying the patch will be difficult because it involves a fundamental change. Would maintaining different versions of xenstore to resolve this issue? If not, would you suggest another solution? Unfortunately, ocamlPackages.xenstore-tool doesn't accept issues.

This should fix it: xapi-project/ocaml-xenstore-clients#23

@ulrikstrid
Copy link
Member

Hello, sorry for not answering earlier @last-genius, I've been somewhat AFK for a while.

It looks like ocamlPackages.xenstore-tool has merged the changes to allow depending on this version now? If that's not the case it looks like it would be trivial to have two versions of this package until that is the case.

@last-genius
Copy link

Hello, sorry for not answering earlier @last-genius, I've been somewhat AFK for a while.

It looks like ocamlPackages.xenstore-tool has merged the changes to allow depending on this version now?

Indeed, xenstore-tool has been updated to allow depending on this version of the library

@ulrikstrid
Copy link
Member

Indeed, xenstore-tool has been updated to allow depending on this version of the library

If you have the bandwidth to bump that package as well we can get this merged then 👍

@last-genius
Copy link

If you have the bandwidth to bump that package as well we can get this merged then 👍

I am not the nix maintainer of these packages, just the upstream one :) we've bumped xenstore-tool to 1.5.0 upstream: https://github.com/xapi-project/ocaml-xenstore-clients/releases/tag/v1.5.0

(if nobody else steps up, I guess I could try and bump the nix package of it too)

@last-genius
Copy link

If you have the bandwidth to bump that package as well we can get this merged then 👍

I am not the nix maintainer of these packages, just the upstream one :) we've bumped xenstore-tool to 1.5.0 upstream: https://github.com/xapi-project/ocaml-xenstore-clients/releases/tag/v1.5.0

(if nobody else steps up, I guess I could try and bump the nix package of it too)

Looks like it was bumped already: #427449

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulrikstrid ulrikstrid Awaiting requested review from ulrikstrid

Assignees
No one assigned
Labels
6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 6.topic: xen-project Issues and PRs related to the Xen Project Hypervisor. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@momeemt @psafont @last-genius @ulrikstrid