Skip to content

kops: add 1.31, 1.32, 1.33, drop 1.27, 1.28, 1.29, 1.30, set default 1.33 #413580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

kops: add 1.31, 1.32, 1.33, drop 1.27, 1.28, 1.29, 1.30, set default 1.33 #413580

wants to merge 1 commit into from

Conversation

whitespire
Copy link

@whitespire whitespire commented Jun 3, 2025 •
edited
Loading

Things done

  • drop kops_1_27, kops_1_28, kops_1_29, kops_1_30
  • init kops_1_31 at 1.31.0
  • init kops_1_32 at 1.32.1
  • init kops_1_33 at 1.33.0
  • set kops_1_33 as default as latest stable release

Why

kOps introduces new major Kubernetes version support with each major release. Considering only latest 3 versions of Kubernetes are maintained and the latest major Kubernetes version is 1.34, nixpkgs have for a while provided kOps packages without support for up-to-date kubernetes. This PR aims to fix that.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 3, 2025
@nix-owners nix-owners bot requested review from yurrriq, offlinehacker and zimbatm June 3, 2025 12:48
@NixOSInfra NixOSInfra added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 3, 2025
@yurrriq
Copy link
Member

yurrriq commented Jun 24, 2025

Thanks, copying from top-level.nix:

In general we only want keep the last three minor versions around that
correspond to the last three supported kubernetes versions:
https://kubernetes.io/docs/setup/release/version-skew-policy/#supported-versions
Exceptions are versions that we need to keep to allow upgrades from older NixOS releases

With that in mind, should we drop 1.29 now too?

yurrriq
yurrriq reviewed Jun 24, 2025
View reviewed changes
pkgs/top-level/all-packages.nix Outdated
;
kops = kops_1_29;
kops = kops_1_32;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mention this in the 25.11 release notes, including any breaking changes.

Glancing at the following...

... it looks like we should probably link/mention https://kops.sigs.k8s.io/tutorial/upgrading-kubernetes/, at least.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given https://endoflife.date/kubernetes, I suppose we should backport this to 25.05 as well.

@whitespire whitespire changed the title kops: add 1.31, 1.32, drop 1.27, 1.28, set default 1.32 kops: add 1.31, 1.32, drop 1.27, 1.28, 1.29, set default 1.32 Jul 21, 2025
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 21, 2025
yurrriq
yurrriq reviewed Jul 23, 2025
View reviewed changes
@nixpkgs-ci nixpkgs-ci bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Aug 18, 2025
kops: add 1.31, 1.32, drop 1.27, 1.28, 1.29, set default 1.33
ddc00ea 
kops: add 1.31, 1.32, drop 1.27, 1.28, 1.29  set default 1.32
@whitespire whitespire changed the title kops: add 1.31, 1.32, drop 1.27, 1.28, 1.29, set default 1.32 kops: add 1.31, 1.32, 1.33 drop 1.27, 1.28, 1.29, 1.30 set default 1.33 Aug 18, 2025
@whitespire
Copy link
Author

In the time this PR was in review there was a new major and a new minor kOps release. I have therefore updated the versions of the packages so that the PR does not become obsolete.

@whitespire whitespire changed the title kops: add 1.31, 1.32, 1.33 drop 1.27, 1.28, 1.29, 1.30 set default 1.33 kops: add 1.31, 1.32, 1.33, drop 1.27, 1.28, 1.29, 1.30, set default 1.33 Aug 18, 2025
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurrriq yurrriq yurrriq left review comments

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@whitespire @yurrriq @wegank @NixOSInfra