Freecad: fix cursor.pcf font load crash #412903
Conversation
|
Might an upstream PR make sense if it crashes not just on NixOS? |
|
i also can't reproduce the issue |
|
cursor.pcf is used for X11's mouse cursor. |
|
Right. What about upstreaming the patch? Your changes itself do look fine, i am not opposed against this patch. But opening an upstream PR might fix it for more than just nix users while also getting "official" reviews. |
|
Good points. done. |
|
After a backlink in nix (so the next person updating the package can check whether it was merged) this is ready |
update update update
27b02d1 to
f1c4f54
Compare
|
Successfully created backport PR for |
See,
#346740
#284880
https://discourse.nixos.org/t/freecad-failed-to-compute-left-right-minimum-bearings-for-cursor-pcf/35266
FreeCAD/FreeCAD#10514
This change blacklists the cursor.pcf font from being background saved into the preferences serialization file.
When this font is loaded, extents cannot be computed, and Freecad freezes at 100% cpu, with errors streamed to stderr.
A proposed workaround, that involves manually editing ~/.config/FreeCAD/user.cfg, to clear the cursor.pcf field when modified, only goes so far.
Since some actions that trigger the behavior - such as DXF import and export - don't provide any opportunity to save work, before one has to perform the pkil, and re-edit the user.cfg, so it is not possible to progress the design.
The change is similar to
FreeCAD/FreeCAD#10555
The proposed fix,
FreeCAD/FreeCAD@9806a46
(now reverted) did not work for me.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.