replibyte: don't vendor Cargo.lock file, add patch for wasm-bindgen #408913
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's an interesting situation:
As some might know, Rust
1.80
broke certain versions of the time crate, so all packages using it needed to bump the version of the time crate they used.This package also seemed to use a broken version of the time crate so a PR was made to bump the
time
crate version: #356469However, turns out the package doesn't actually depend on a broken version of the time crate:
only versions between
0.3.18
and0.3.54
were affected, and according to theCargo.lock
inside thesrc
, this package only uses0.3.9
and below.So why was it broken anyway?
It turns out, for whatever reason, in #294960, when this package was last version-bumped, the
Cargo.lock
wasn't copied fromsrc
, but from somewhere else, (maybe some other, newer revision, or maybe it was generated manually, idk).And in that lockfile, the
time
crate used was version0.3.36
; so it was affected by the breakage.This means we could have just used the original Cargo.lock file the whole time... Cool.
However, since then, we have reached an even newer version of Rust, which doesn't support the old version of
wasm-bindgen
in the actual lockfile.But since the lockfile currently vendored just accidentally handled this issue because it already contains a more updated version of
wasm-bindgen
.But once I reverted to using the lockfile from
src
, thewasm-bindgen
issue did actually appear, so I had to keep the version bump ofwasm-bindgen
as a patch.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.