Skip to content

pythonPackages.mistralai: init at 1.7.0 #407954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

pythonPackages.mistralai: init at 1.7.0 #407954

wants to merge 2 commits into from
+60 −0

Conversation

jbrocher
Copy link

@jbrocher jbrocher commented May 17, 2025 •
edited
Loading

Add the python client for mistral : https://github.com/mistralai/client-python

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label May 17, 2025
@nix-owners nix-owners bot requested a review from natsukium May 17, 2025 13:24
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 17, 2025
@NixOSInfra NixOSInfra added the 12.first-time contribution This PR is the author's first one; please be gentle! label May 17, 2025
@jbrocher jbrocher force-pushed the python-packages/mistralai branch from 77a0f45 to 7ca06ee Compare May 17, 2025 13:49
@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label May 17, 2025
@jbrocher jbrocher force-pushed the python-packages/mistralai branch from 7ca06ee to bce3be1 Compare May 17, 2025 13:59
@jbrocher jbrocher force-pushed the python-packages/mistralai branch from bce3be1 to ab0c687 Compare May 17, 2025 14:01
amadejkastelic
amadejkastelic reviewed May 17, 2025
View reviewed changes
Copy link
Member

@amadejkastelic amadejkastelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files are not properly formatted. Look into https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#formatting.

@jbrocher jbrocher force-pushed the python-packages/mistralai branch from cff7f77 to 9e4692c Compare May 18, 2025 08:01
@jbrocher
Copy link
Author

@amadejkastelic thank you some much for taking the time to review this, I learned a lot :D

I've implemented the requested changes in additional commits. Let me know everything checks out and I'll squash them

amadejkastelic
amadejkastelic reviewed May 18, 2025
View reviewed changes
Copy link
Member

@amadejkastelic amadejkastelic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash the commits, there should only be two - https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#commit-conventions

Edit: sorry, missed your comment above, looks good to me now.

@amadejkastelic
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 407954

x86_64-linux

✅ 4 packages built:
  • python312Packages.mistralai
  • python312Packages.mistralai.dist
  • python313Packages.mistralai
  • python313Packages.mistralai.dist

@jbrocher jbrocher force-pushed the python-packages/mistralai branch from 0594c5c to 63f506d Compare May 18, 2025 09:58
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label May 18, 2025
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5569

@jbrocher
Copy link
Author

Hello @natsukium! If you have some time, I'd be grateful if you could take a look at this :)

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natsukium natsukium Awaiting requested review from natsukium

2 more reviewers

@amadejkastelic amadejkastelic amadejkastelic approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
6.topic: python Python is a high-level, general-purpose programming language. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jbrocher @amadejkastelic @nixos-discourse @wegank @NixOSInfra