Skip to content

readexpro: init at 1.2 #407653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

readexpro: init at 1.2 #407653

wants to merge 2 commits into from

Conversation

S-K-Tiger
Copy link

@S-K-Tiger S-K-Tiger commented May 16, 2025 •
edited
Loading

Things done

Added myself as a maintainer.
Added a font package.
Simply downloads font files from a repo and puts them in $out/share/fonts/

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 16, 2025
@S-K-Tiger S-K-Tiger marked this pull request as draft May 16, 2025 15:45
@S-K-Tiger S-K-Tiger force-pushed the readexpro branch 3 times, most recently from 7f8020a to ec90650 Compare May 17, 2025 14:21
@S-K-Tiger
Copy link
Author

Turns out I didn't use nixpkgs-review correctly; and even after trying things like nixpkgs-review rev -r ./ -p readexpro {local commit} it kept complaining the package didn't exist.
So instead I read the workflow files to see how they did it and switched to using nix-build ./ci -A fmt.check && nix-build ./pkgs/data/fonts/readexpro --keep-going && nix-build ./ci -A parse --keep-going.
Let me know if you know what I did wrong.

pluiedev
pluiedev suggested changes May 17, 2025
View reviewed changes
Copy link
Member

@pluiedev pluiedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to Nixpkgs! Just a few things:

@pluiedev
Copy link
Member

pluiedev commented May 17, 2025 •
edited
Loading

Also: new packages need to use the pkgs/by-name scheme (so in this case, move pkgs/data/fonts/readexpro/default.nix to pkgs/by-name/re/readexpro/package.nix). The PR title should also ideally be the same as the main commit (readexpro: init at 1.2).

@pluiedev pluiedev added the 12.first-time contribution This PR is the author's first one; please be gentle! label May 17, 2025
@S-K-Tiger S-K-Tiger changed the title Readexpro readexpro: init at 1.2 May 17, 2025
@S-K-Tiger S-K-Tiger force-pushed the readexpro branch 4 times, most recently from a96a412 to 624e3d2 Compare May 17, 2025 15:50
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 17, 2025
@S-K-Tiger S-K-Tiger marked this pull request as ready for review May 17, 2025 17:49
pluiedev
pluiedev approved these changes May 17, 2025
View reviewed changes
Copy link
Member

@pluiedev pluiedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for one small nitpick

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label May 18, 2025
@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels May 27, 2025
@Sigmanificient
Copy link
Member

Sigmanificient commented Aug 15, 2025 •
edited
Loading

Reopened for CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@JuliusFreudenberger JuliusFreudenberger JuliusFreudenberger approved these changes

@pluiedev pluiedev pluiedev approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@S-K-Tiger @pluiedev @Sigmanificient @JuliusFreudenberger @wegank