Skip to content

python3Packages.netbox-contract: 2.3.2 -> 2.4.0 #406278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2025
Merged

python3Packages.netbox-contract: 2.3.2 -> 2.4.0 #406278

merged 1 commit into from
Jun 1, 2025

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for python3Packages.netbox-contract is: Contract plugin for netbox

meta.homepage for python3Packages.netbox-contract is: https://github.com/mlebreuil/netbox-contract

meta.changelog for python3Packages.netbox-contract is: https://github.com/mlebreuil/netbox-contract/releases/tag/v2.4.0

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact

Checks done

  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 2.4.0 with grep in /nix/store/w9r7ambhnljsprcdcaiail34kgzqzk29-python3.12-netbox-contract-2.4.0
  • found 2.4.0 in filename of file in /nix/store/w9r7ambhnljsprcdcaiail34kgzqzk29-python3.12-netbox-contract-2.4.0
Rebuild report (if merged into master) (click to expand) 
2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

python312Packages.netbox-contract
Instructions to test this update (click to expand)

Either download from the cache:

nix-store -r /nix/store/w9r7ambhnljsprcdcaiail34kgzqzk29-python3.12-netbox-contract-2.4.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nixpkgs-update-cache.nix-community.org/' \
  --option trusted-public-keys '
  nixpkgs-update-cache.nix-community.org-1:U8d6wiQecHUPJFSqHN9GSSmNkmdiFW7GW7WNAnHW0SM=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The nixpkgs-update cache is only trusted for this store-path realization.)
For the cached download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A python3Packages.netbox-contract https://github.com/r-ryantm/nixpkgs/archive/9fb331fa8ca76a636754aca3920769587cdc1240.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/9fb331fa8ca76a636754aca3920769587cdc1240#python3Packages.netbox-contract

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/w9r7ambhnljsprcdcaiail34kgzqzk29-python3.12-netbox-contract-2.4.0
ls -la /nix/store/w9r7ambhnljsprcdcaiail34kgzqzk29-python3.12-netbox-contract-2.4.0/bin

Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review

x86_64-linux

✅ 2 packages built:
  • python312Packages.netbox-contract
  • python312Packages.netbox-contract.dist
Maintainer pings

cc @felbinger for testing.

Tip

As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 11, 2025
@nix-owners nix-owners bot requested a review from felbinger May 11, 2025 22:13
@wolfgangwalther wolfgangwalther merged commit 1f09afa into NixOS:master Jun 1, 2025
27 checks passed
@r-ryantm r-ryantm deleted the auto-update/python3Packages.netbox-contract branch June 2, 2025 00:21
@felbinger
Copy link
Member

felbinger commented Jun 2, 2025 •
edited
Loading

According to the README of this project netbox 4.3 is required, so this won't work!
Unfortunately I oversaw the review request and just got pinged today.

It's common for netbox plugins to only work with a specific version of netbox, same as for:

We need to wait until this has been merged:

@wolfgangwalther
Copy link
Contributor

Hmmm.. a couple of thoughts:

  • We have netbox_4_1 and netbox_4_2 right now. With the current setup, plugins won't work with both of them, right?
  • Any plan to package netbox_4_3, yet?
  • How can we find a way that avoids creating a mass of plugin update PRs, which we all need to be aware of that they don't work - especially when all tests are green?

@SuperSandro2000 SuperSandro2000 mentioned this pull request Jun 2, 2025
Merged
@SuperSandro2000
Copy link
Member

@felbinger did so in #413232

@wolfgangwalther wolfgangwalther mentioned this pull request Jun 2, 2025
Draft
@felbinger
Copy link
Member

Hmmm.. a couple of thoughts:

* We have `netbox_4_1` and `netbox_4_2` right now. With the current setup, plugins won't work with both of them, right?

* Any plan to package `netbox_4_3`, yet?

* How can we find a way that avoids creating a mass of plugin update PRs, which we all need to be aware of that they don't work - especially when all tests are green?

I'd love to have a way to handle this...
I asked in #312861 (comment) if we have something like this.
Netbox maintained responded with this: #312861 (comment)
So right now I don't think we can solve this problem

@felbinger
Copy link
Member

We have netbox_4_1 and netbox_4_2 right now. With the current setup, plugins won't work with both of them, right?

The primarily problem is that there were changes in the plugin system of netbox. Due to breaking changes in 4.3 I'm not sure if this is going to work for these versions.

I'd prefer a solution where plugins are also versioned in any way, so that a netbox plugin can be loaded for the supported netbox version e.g. using an option in the services.netbox module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felbinger felbinger Awaiting requested review from felbinger

Assignees
No one assigned
Labels
6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@r-ryantm @felbinger @wolfgangwalther @SuperSandro2000