Skip to content

antares: 0.7.29 -> 0.7.34 #405372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

antares: 0.7.29 -> 0.7.34 #405372

wants to merge 1 commit into from

Conversation

hatch01
Copy link
Contributor

@hatch01 hatch01 commented May 8, 2025

Things done

antares: 0.7.29 -> 0.7.34

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 8, 2025
phanirithvij
phanirithvij suggested changes May 10, 2025
View reviewed changes
Copy link
Member

@phanirithvij phanirithvij left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is best to de-vendor this huge lock file patch.
My suggestion would be to make a PR to antares for the same and
use https://github.com/antares-sql/antares/pull/<prno>.patch?full_index=1 and fetchpatch2

@phanirithvij

This comment was marked as outdated.

Sign in to view
@phanirithvij phanirithvij requested a review from Atemu May 10, 2025 03:53
@Mic92
Copy link
Member

Mic92 commented May 10, 2025

I think it is best to de-vendor this huge lock file patch. My suggestion would be to make a PR to antares for the same and use https://github.com/antares-sql/antares/pull/<prno>.patch?full_index=1 and fetchpatch2

Sounds ok in principle. But we may should long-term think about having some place where we can store these forks in case contribute (accidentally) delete them.

@hatch01
Copy link
Contributor Author

hatch01 commented May 10, 2025 •
edited
Loading

In this pr #335924,
I followed @emilazy advice.
And I think that nixpkgs guidline prefer to keep those kind of path in nixpkgs.

Moreover, I don't really think that the repo checkout is a big problem. As the repo is already huge

@Mic92 Mic92 mentioned this pull request May 10, 2025
Open
@emilazy
Copy link
Member

emilazy commented May 10, 2025

We specifically don’t allow devendoring patches for unmerged GitHub PRs; see #401863 for the latest discussion.

It would be better if upstream fixes this though.

@phanirithvij phanirithvij added the 12.approvals: 1 This PR was reviewed and approved by one person. label May 11, 2025
@phanirithvij phanirithvij mentioned this pull request Jun 14, 2025
Closed
13 tasks
@hatch01 hatch01 mentioned this pull request Aug 9, 2025
Open
@nixpkgs-ci nixpkgs-ci bot added the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Aug 9, 2025
phanirithvij
phanirithvij reviewed Aug 16, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Atemu Atemu Awaiting requested review from Atemu

1 more reviewer

@phanirithvij phanirithvij phanirithvij approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hatch01 @phanirithvij @Mic92 @emilazy