legendsviewer-next: init at 1.2.0 #405918
Conversation
390bd38 to
a1f5d94
Compare
|
@ofborg eval |
219c7a9 to
2f45df8
Compare
|
@NixOS/dotnet First time contributor here. If someone is willing, could someone take a look at this? It also has a node subpackage, not sure who to tag about that. |
604cd7d to
0bd483c
Compare
|
Updated base to latest nixpkgs-unstable |
|
Hey, @GGG-KILLER , if you have time/ are able, could you look at this package pull request? I just updated the base, but it was passing ofberg checks before. Thanks in advance! |
|
Oh hello, I'm sorry, didn't see this, my bad. I'm a bit busy right now but I'll make sure to have this reviewed by tomorrow! |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/nix-channel-forcing-an-update/64940/1 |
|
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5587 |
|
@emaryn I tested these changes on my system, it should be working on the latest nixpkgs-unstable Done:
The only question I have is about the tests. By nature of it being a server/web app, it opens two ports. The build could fail due to system state in a non reproducible way. Exacerbating this are the ports chosen, web app on port 8081 with the API on port 5054 (I may suggest changes upstream). I think the web app should fail to run at runtime due to this, not fail to build. So is there a reason we aren't using passthru to avoid the tests being run on the user system (it also would shave off 5-10 seconds off the build)? |
|
@emaryn seems to have been deleted off of GitHub and their suggestions removed. Are there any other reviewers you would suggest? Thanks. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5758 |
f332234 to
f8212c4
Compare
This adds legendsviewer-next, a Dwarf Fortress exported legends viewer
f8212c4 to
a5bb05f
Compare
|
#405918 (comment) did not work on darwin due to how it handles dangling processes. The server needs to be spawned and waited until it's ready (by watching stdout), then killed after when we are done testing. It turns out coproc is perfect for this, so I used that instead. Hopefully no other darwin-related incompatibilities result. @ofborg eval |
Add legendsviewer-next
Commits
Description
LegendsViewer-Next is a cross-platform revamp (by the same author) of the original Windows-only LegendsViewer, a legends-mode explorer for the indie game Dwarf Fortress. LegendsViewer-Next supports world information overviews, maps, populations, war/battle death tolls, and has a very user-friendly interface.
LegendsViewer-Next hosts a web app on port 8081 with the api on port 5054. Its configuration on Linux is stored at
~/.config/LegendsViewer, currently onlybookmarks.json.Tests
Currently, there is one unit test, which makes sure the frontend serves an html document and the backend reports the correct version, and both are working.
Things done
nix.conf? (See Nix manual)[ ]sandbox = relaxedsandbox = trueNixOS test(s) (look inside nixos/tests)or, for functions and "core" functionality, tests in lib/tests or pkgs/testmade sure NixOS tests are linked to the relevant packagesnix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)[ ] (Package updates) Added a release notes entry if the change is major or breaking[ ] (Module updates) Added a release notes entry if the change is significant[ ] (Module addition) Added a release notes entry if adding a new NixOS moduleAdd a 👍 reaction to pull requests you find important.