netbox: 4.3.5 -> 4.3.6 #405880
netbox: 4.3.5 -> 4.3.6 #405880
Conversation
|
4.3.0 has breaking changes, so it needs to be a separate package. Let's also wait for #401110 first. |
864bafe to
9c5dd51
Compare
|
Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript. meta.description for netbox is: IP address management (IPAM) and data center infrastructure management (DCIM) tool meta.homepage for netbox is: https://github.com/netbox-community/netbox Updates performed
To inspect upstream changesImpactChecks done
Caution A test defined in
Rebuild report (if merged into master) (click to expand)Instructions to test this update (click to expand)Either download from the cache: (The nixpkgs-update cache is only trusted for this store-path realization.) Or, build yourself: Or: After you've downloaded or built it, look at the files and if there are any, run the binaries: Pre-merge build resultsWe have automatically built all packages that will get rebuilt due to This gives evidence on whether the upgrade will break dependent packages.
|
|
@minijackson the linked PR got merged, so we can tackle this now or is there another requirement in the meantime? |
Why does it have to be a separate package? I learned in #406278, that plugins don't support multiple versions, so packaging multiple versions of netbox, but only a single version of each plugin is a bit pointless, right? Why not revert back to a single |
|
@SuperSandro2000 yes, we can. I can do it when I have the time, but if someone else wants to do it, it'll probably be faster. @wolfgangwalther you're right that we don't need to support multiple version of the package. The way it's done today isn't to give the choice of which version of NetBox to use. It's more to do with warning the user that the upgrade has breaking changes. So when the user upgrades from 24.11 to 25.05, they'll get a eval error, saying "there's breaking changes in NetBox, look at the release notes, do what you have to do, then edit your NixOS config to say that you've done your pre-upgrade tasks." We can definitely do this without having to support multiple NetBox versions, for example with But my guess is that we're not the only ones in this scenario, do you all know of some service doing something like this? |
|
@minijackson i started with 4.3 in #414367 |
I see. In this case, there should be one version specific netbox attribute - and the older version should fail with an error. But right now, we have |
9c5dd51 to
3adfb57
Compare
|
Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript. meta.description for netbox is: IP address management (IPAM) and data center infrastructure management (DCIM) tool meta.homepage for netbox is: https://github.com/netbox-community/netbox Updates performed
To inspect upstream changesImpactChecks done
Caution A test defined in
Rebuild report (if merged into master) (click to expand)Instructions to test this update (click to expand)Either download from the cache: (The nixpkgs-update cache is only trusted for this store-path realization.) Or, build yourself: Or: After you've downloaded or built it, look at the files and if there are any, run the binaries: Pre-merge build resultsWe have automatically built all packages that will get rebuilt due to This gives evidence on whether the upgrade will break dependent packages.
|
3adfb57 to
7ea17bd
Compare
|
Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript. meta.description for netbox is: IP address management (IPAM) and data center infrastructure management (DCIM) tool meta.homepage for netbox is: https://github.com/netbox-community/netbox meta.changelog for netbox is: https://github.com/netbox-community/netbox/blob/v4.3.4/docs/release-notes/version-4.3.md Updates performed
To inspect upstream changesImpactChecks done
Rebuild report (if merged into master) (click to expand)Instructions to test this update (click to expand)Either download from the cache: (The nixpkgs-update cache is only trusted for this store-path realization.) Or, build yourself: Or: After you've downloaded or built it, look at the files and if there are any, run the binaries: Pre-merge build resultsWe have automatically built all packages that will get rebuilt due to This gives evidence on whether the upgrade will break dependent packages.
|
|
Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript. meta.description for netbox is: IP address management (IPAM) and data center infrastructure management (DCIM) tool meta.homepage for netbox is: https://github.com/netbox-community/netbox meta.changelog for netbox is: https://github.com/netbox-community/netbox/blob/v4.3.6/docs/release-notes/version-4.3.md Updates performed
To inspect upstream changesImpactChecks done
Caution A test defined in
Rebuild report (if merged into master) (click to expand)Instructions to test this update (click to expand)Either download from the cache: (The nixpkgs-update cache is only trusted for this store-path realization.) Or, build yourself: Or: After you've downloaded or built it, look at the files and if there are any, run the binaries: Pre-merge build resultsWe have automatically built all packages that will get rebuilt due to This gives evidence on whether the upgrade will break dependent packages.
|
7ea17bd to
71b9948
Compare
Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for netbox is: IP address management (IPAM) and data center infrastructure management (DCIM) tool
meta.homepage for netbox is: https://github.com/netbox-community/netbox
Updates performed
To inspect upstream changes
Impact
Checks done
Caution
A test defined in
passthru.testsdid not pass.Rebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Either download from the cache:
(The nixpkgs-update cache is only trusted for this store-path realization.)
For the cached download to work, your user must be in the
trusted-userslist or you can usesudosince root is effectively trusted.Or, build yourself:
Or:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-reviewresultGenerated using
nixpkgs-review.Command:
nixpkgs-reviewx86_64-linux✅ 39 packages built:
Maintainer pings
cc @minijackson @RaitoBezarius for testing.
Tip
As a maintainer, if your package is located under
pkgs/by-name/*, you can comment@NixOS/nixpkgs-merge-bot mergeto automatically merge this update using thenixpkgs-merge-bot.Add a 👍 reaction to pull requests you find important.