suwayomi-server: refactor; suwayomi-webui: init at 1.5.1 #404187
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RatCornu
reviewed
May 5, 2025
There was a problem hiding this comment.
Thanks for the PR! While on the branch, with the small correction of the folder, I can build and run the binary successfully. However, the tests fail with the following logs:
java.io.IOException: raw.githubusercontent.com
at suwayomi.tachidesk.server.util.WebInterfaceManager$fetchServerMappingFile$2.invokeSuspend(WebInterfaceManager.kt:518)
at suwayomi.tachidesk.server.util.WebInterfaceManager$fetchServerMappingFile$2.invoke(WebInterfaceManager.kt)
at suwayomi.tachidesk.server.util.WebInterfaceManager$fetchServerMappingFile$2.invoke(WebInterfaceManager.kt)
at suwayomi.tachidesk.server.util.WebInterfaceManager.executeWithRetry(WebInterfaceManager.kt:464)
at suwayomi.tachidesk.server.util.WebInterfaceManager.executeWithRetry(WebInterfaceManager.kt:469)
at suwayomi.tachidesk.server.util.WebInterfaceManager.access$executeWithRetry(WebInterfaceManager.kt:75)
at suwayomi.tachidesk.server.util.WebInterfaceManager$executeWithRetry$1.invokeSuspend(WebInterfaceManager.kt)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:98)
at kotlinx.coroutines.EventLoopImplBase.processNextEvent(EventLoop.common.kt:263)
at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Builders.kt:95)
at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Builders.kt:69)
at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source)
at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Builders.kt:47)
at kotlinx.coroutines.BuildersKt.runBlocking$default(Unknown Source)
at suwayomi.tachidesk.server.JavalinSetup.javalinSetup$lambda$10(JavalinSetup.kt:52)
at io.javalin.config.JavalinConfig$Companion.applyUserConfig(JavalinConfig.kt:107)
at io.javalin.config.JavalinConfig.applyUserConfig(JavalinConfig.kt)
at io.javalin.Javalin.create(Javalin.java:73)
at suwayomi.tachidesk.server.JavalinSetup.javalinSetup(JavalinSetup.kt:45)
at suwayomi.tachidesk.MainKt.main(Main.kt:15)
at suwayomi.tachidesk.MainKt.main(Main.kt)
Caused by: java.net.UnknownHostException: raw.githubusercontent.com
at java.base/java.net.InetAddress$CachedLookup.get(InetAddress.java:988)
at java.base/java.net.InetAddress.getAllByName0(InetAddress.java:1818)
at java.base/java.net.InetAddress.getAllByName(InetAddress.java:1688)
...
I don't know what could be the cause of this issue, but this made Ofbord timeout during the tests.
Moreover, I pushed a new commit on my PR to use runTest instead of handleTest, this will not change your PR but you should rebase once mine has been merged
|
It seems like suwayomi-server bundles the WebUI from this repository. I'll push a revision with another suwayomi-webui package and addressing the comments soon |
af4807f to
d70f678
Compare
|
@RatCornu I hope you don't mind me putting you into the maintainers list for suwayomi-webui. Let me know if I should change that! |
I'm completely fine with that, do not worry: I hope it will make updates easier to merge ^^ |
Changed the package to build it from source
|
I'll update this once the update PR is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds the package from source instead of pulling the jar from the release binaries
Depends on #400589
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.