espanso: adding packages from espanso/hub as plugins #403156
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delafthi
added a commit
to delafthi/home-manager
that referenced
this pull request
Apr 30, 2025
This commit requires NixOS/nixpkgs#403156 to be merged into nixpkgs.
delafthi
added a commit
to delafthi/home-manager
that referenced
this pull request
Apr 30, 2025
This commit requires NixOS/nixpkgs#403156 to be merged into nixpkgs.
delafthi
added a commit
to delafthi/home-manager
that referenced
this pull request
Apr 30, 2025
This commit requires NixOS/nixpkgs#403156 to be merged into nixpkgs.
delafthi
added a commit
to delafthi/home-manager
that referenced
this pull request
Apr 30, 2025
This commit requires NixOS/nixpkgs#403156 to be merged into nixpkgs.
6 tasks
|
Wow, awesome effort here! Please review the PR naming conventions; I think you'll be expected to squash this into two commits: one for adding yourself to the list of maintainers, and a second that will be something along the lines of |
|
Thank you for the feedback. I have structured the commits as follows:
To streamline the process of committing each plugin, I add the If there are any further suggestions or adjustments needed, please let me know. |
|
In the recent force-push, I took the time to manually go through all the plugins and add |
bb43a34 to
cf904fd
Compare
|
Changed my email address and GPG key, so updated the maintainer list accordingly. Rebased the branch onto the latest master. |
n8henrie
approved these changes
Jun 10, 2025
|
I’ve reached out on the nixpkgs review request matrix channel to ask someone with experience with plugins in nixpkgs to review this PR. Hopefully, we’ll get more insights soon. |
This commit introduces the `mkEspansoPlugin` function along with an update script that allows users to seamlessly add and update Espanso packages from the [espanso/hub](https://github.com/espanso/hub) repository. The new functionality enables the integration of these packages as plugins under the configuration key `espansoPlugins.<name>`.
|
Updated the update script to allow specifying the VCS tool for the Fixed an issue with Also ran the update script to update/add packages. |
|
|
@drupol Sry, to bother you, but would it be possible to merge this PR? Then I could proceed with the home-manager implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Espanso packages from github:espanso/hub as plugins under
espansoPlugins.<name>. Accordingly, we also introduce apluginsoption to the Espanso Home-Manager service to allow users to easily add these plugins.meta.license) must be added manually, so I reviewed each package and added the appropriate license metadata accordingly.packages/<package-name>/<most-recent-version>/to the output directory.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.