nixos/nextcloud: Use require_once to load override.config.php #403434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses a peculiar bug I encountered where certain apps would fail to load and log 'Cannot redeclare nix_read_secret()'. Even if I haven't found the root cause, this error makes a valid point as we cannot control how many times Nextcloud tries to load config.php in a single page load. This solution is more robust than the bare symbolic link.
|
Nextcloud will never load the config files twice per request, so I don't think this change makes sense. There must be something else going on. |
Yet it does, and even if it didn't, nowhere is it guaranteed nor does vanilla Nextcloud need to test for this. Honestly, I'd rather hear a genuine issue with my PR than "the issue it addresses doesn't exist". What does NixOS lose by implementing this fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses a peculiar bug I encountered where certain apps would fail to load and log
Cannot redeclare nix_read_secret().Even if I haven't found the root cause, this error makes a valid point as we cannot control how many times Nextcloud tries to load config.php in a single page load. This solution is more robust than the bare symbolic link.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.