Skip to content

NetBox: 4.2.7 -> 4.2.9 + cleanup #401110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 15, 2025
Merged

NetBox: 4.2.7 -> 4.2.9 + cleanup #401110

merged 7 commits into from
May 15, 2025

Conversation

minijackson
Copy link
Member

@minijackson minijackson commented Apr 23, 2025 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Apr 23, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Apr 23, 2025
@nix-owners nix-owners bot requested a review from RaitoBezarius April 23, 2025 12:43
@minijackson minijackson mentioned this pull request Apr 23, 2025
Closed
13 tasks
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 23, 2025
@transcaffeine
Copy link
Contributor

Also successfully built on aarch64-darwin:

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 401110

aarch64-darwin

✅ 23 packages built:
  • netbox
  • python312Packages.netbox-bgp
  • python312Packages.netbox-bgp.dist
  • python312Packages.netbox-documents
  • python312Packages.netbox-documents.dist
  • python312Packages.netbox-floorplan-plugin
  • python312Packages.netbox-floorplan-plugin.dist
  • python312Packages.netbox-plugin-prometheus-sd
  • python312Packages.netbox-plugin-prometheus-sd.dist
  • python312Packages.netbox-reorder-rack
  • python312Packages.netbox-reorder-rack.dist
  • python312Packages.netbox-routing
  • python312Packages.netbox-routing.dist
  • python313Packages.netbox-bgp
  • python313Packages.netbox-bgp.dist
  • python313Packages.netbox-documents
  • python313Packages.netbox-documents.dist
  • python313Packages.netbox-plugin-prometheus-sd
  • python313Packages.netbox-plugin-prometheus-sd.dist
  • python313Packages.netbox-reorder-rack
  • python313Packages.netbox-reorder-rack.dist
  • python313Packages.netbox-routing
  • python313Packages.netbox-routing.dist

@transcaffeine
Copy link
Contributor

netbox 4.2.9 was just released: https://github.com/netbox-community/netbox/releases/tag/v4.2.9

@minijackson minijackson mentioned this pull request May 11, 2025
Draft
@minijackson
Copy link
Member Author

@transcaffeine done

@minijackson minijackson changed the title NetBox: 4.2.7 -> 4.2.8 + cleanup NetBox: 4.2.7 -> 4.2.9 + cleanup May 13, 2025
@minijackson minijackson requested a review from transcaffeine May 13, 2025 12:01
transcaffeine
transcaffeine approved these changes May 13, 2025
View reviewed changes
Copy link
Contributor

@transcaffeine transcaffeine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 401110

x86_64-linux

✅ 39 packages built:
  • netbox
  • python312Packages.netbox-attachments
  • python312Packages.netbox-attachments.dist
  • python312Packages.netbox-bgp
  • python312Packages.netbox-bgp.dist
  • python312Packages.netbox-contract
  • python312Packages.netbox-contract.dist
  • python312Packages.netbox-documents
  • python312Packages.netbox-documents.dist
  • python312Packages.netbox-floorplan-plugin
  • python312Packages.netbox-floorplan-plugin.dist
  • python312Packages.netbox-interface-synchronization
  • python312Packages.netbox-interface-synchronization.dist
  • python312Packages.netbox-napalm-plugin
  • python312Packages.netbox-napalm-plugin.dist
  • python312Packages.netbox-plugin-prometheus-sd
  • python312Packages.netbox-plugin-prometheus-sd.dist
  • python312Packages.netbox-qrcode
  • python312Packages.netbox-qrcode.dist
  • python312Packages.netbox-reorder-rack
  • python312Packages.netbox-reorder-rack.dist
  • python312Packages.netbox-routing
  • python312Packages.netbox-routing.dist
  • python312Packages.netbox-topology-views
  • python312Packages.netbox-topology-views.dist
  • python313Packages.netbox-bgp
  • python313Packages.netbox-bgp.dist
  • python313Packages.netbox-documents
  • python313Packages.netbox-documents.dist
  • python313Packages.netbox-interface-synchronization
  • python313Packages.netbox-interface-synchronization.dist
  • python313Packages.netbox-plugin-prometheus-sd
  • python313Packages.netbox-plugin-prometheus-sd.dist
  • python313Packages.netbox-qrcode
  • python313Packages.netbox-qrcode.dist
  • python313Packages.netbox-reorder-rack
  • python313Packages.netbox-reorder-rack.dist
  • python313Packages.netbox-routing
  • python313Packages.netbox-routing.dist

aarch64-darwin

❌ 4 packages failed to build:
  • python312Packages.netbox-documents
  • python312Packages.netbox-documents.dist
  • python313Packages.netbox-documents
  • python313Packages.netbox-documents.dist
✅ 19 packages built:
  • netbox
  • python312Packages.netbox-bgp
  • python312Packages.netbox-bgp.dist
  • python312Packages.netbox-floorplan-plugin
  • python312Packages.netbox-floorplan-plugin.dist
  • python312Packages.netbox-plugin-prometheus-sd
  • python312Packages.netbox-plugin-prometheus-sd.dist
  • python312Packages.netbox-reorder-rack
  • python312Packages.netbox-reorder-rack.dist
  • python312Packages.netbox-routing
  • python312Packages.netbox-routing.dist
  • python313Packages.netbox-bgp
  • python313Packages.netbox-bgp.dist
  • python313Packages.netbox-plugin-prometheus-sd
  • python313Packages.netbox-plugin-prometheus-sd.dist
  • python313Packages.netbox-reorder-rack
  • python313Packages.netbox-reorder-rack.dist
  • python313Packages.netbox-routing
  • python313Packages.netbox-routing.dist

the aarch64-darwin build failed due to gdal test failures, might be fixable with a rebase

@minijackson
netbox: setup update script
e01cac1
@minijackson
netbox: 4.2.7 -> 4.2.8
cf7bb0e
@minijackson
nixos/tests/netbox-upgrade: test the 4.1 -> 4.2 upgrade
7c727f9
@minijackson
netbox_4_1: mark EOL
f99dcc2
@minijackson
netbox_3_7: remove
2d0fdeb 
as a transition path,
we already have netbox_4_1 which is EOL
@minijackson
nixos/tests/netbox-upgrade: don't require NIXPKGS_ALLOW_INSECURE
e152cef 
Before this change, this NetBox test required NIXPKGS_ALLOW_INSECURE=1,
because of its use of the end-of-line NetBox version.
This meant that the GitHub CI failed to evaluate the tests,
and so didn't run them.
@minijackson
netbox_4_2: 4.2.8 -> 4.2.9
59e547a
@minijackson minijackson requested a review from transcaffeine May 14, 2025 07:45
transcaffeine
transcaffeine approved these changes May 15, 2025
View reviewed changes
Copy link
Contributor

@transcaffeine transcaffeine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds fine now on aarch64-darwin aswell! :)

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 401110

x86_64-linux

✅ 39 packages built:
  • netbox
  • python312Packages.netbox-attachments
  • python312Packages.netbox-attachments.dist
  • python312Packages.netbox-bgp
  • python312Packages.netbox-bgp.dist
  • python312Packages.netbox-contract
  • python312Packages.netbox-contract.dist
  • python312Packages.netbox-documents
  • python312Packages.netbox-documents.dist
  • python312Packages.netbox-floorplan-plugin
  • python312Packages.netbox-floorplan-plugin.dist
  • python312Packages.netbox-interface-synchronization
  • python312Packages.netbox-interface-synchronization.dist
  • python312Packages.netbox-napalm-plugin
  • python312Packages.netbox-napalm-plugin.dist
  • python312Packages.netbox-plugin-prometheus-sd
  • python312Packages.netbox-plugin-prometheus-sd.dist
  • python312Packages.netbox-qrcode
  • python312Packages.netbox-qrcode.dist
  • python312Packages.netbox-reorder-rack
  • python312Packages.netbox-reorder-rack.dist
  • python312Packages.netbox-routing
  • python312Packages.netbox-routing.dist
  • python312Packages.netbox-topology-views
  • python312Packages.netbox-topology-views.dist
  • python313Packages.netbox-bgp
  • python313Packages.netbox-bgp.dist
  • python313Packages.netbox-documents
  • python313Packages.netbox-documents.dist
  • python313Packages.netbox-interface-synchronization
  • python313Packages.netbox-interface-synchronization.dist
  • python313Packages.netbox-plugin-prometheus-sd
  • python313Packages.netbox-plugin-prometheus-sd.dist
  • python313Packages.netbox-qrcode
  • python313Packages.netbox-qrcode.dist
  • python313Packages.netbox-reorder-rack
  • python313Packages.netbox-reorder-rack.dist
  • python313Packages.netbox-routing
  • python313Packages.netbox-routing.dist

aarch64-darwin

✅ 23 packages built:
  • netbox
  • python312Packages.netbox-bgp
  • python312Packages.netbox-bgp.dist
  • python312Packages.netbox-documents
  • python312Packages.netbox-documents.dist
  • python312Packages.netbox-floorplan-plugin
  • python312Packages.netbox-floorplan-plugin.dist
  • python312Packages.netbox-plugin-prometheus-sd
  • python312Packages.netbox-plugin-prometheus-sd.dist
  • python312Packages.netbox-reorder-rack
  • python312Packages.netbox-reorder-rack.dist
  • python312Packages.netbox-routing
  • python312Packages.netbox-routing.dist
  • python313Packages.netbox-bgp
  • python313Packages.netbox-bgp.dist
  • python313Packages.netbox-documents
  • python313Packages.netbox-documents.dist
  • python313Packages.netbox-plugin-prometheus-sd
  • python313Packages.netbox-plugin-prometheus-sd.dist
  • python313Packages.netbox-reorder-rack
  • python313Packages.netbox-reorder-rack.dist
  • python313Packages.netbox-routing
  • python313Packages.netbox-routing.dist

@minijackson minijackson merged commit 859e55c into NixOS:master May 15, 2025
27 of 28 checks passed
@minijackson minijackson deleted the netbox-4.2.8 branch May 15, 2025 11:33
@minijackson
Copy link
Member Author

@transcaffeine thank you for the reviews!

@transcaffeine transcaffeine mentioned this pull request Jun 5, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaitoBezarius RaitoBezarius Awaiting requested review from RaitoBezarius

1 more reviewer

@transcaffeine transcaffeine transcaffeine approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@minijackson @transcaffeine @wegank