Skip to content

gz-math: init at 8.1.1 #401753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

gz-math: init at 8.1.1 #401753

wants to merge 1 commit into from

Conversation

Guelakais
Copy link
Contributor

@Guelakais Guelakais commented Apr 25, 2025 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 25, 2025
ethancedwards8
ethancedwards8 suggested changes Apr 26, 2025
View reviewed changes
bengsparks
bengsparks suggested changes Apr 26, 2025
View reviewed changes
bengsparks
bengsparks suggested changes Apr 30, 2025
View reviewed changes
@Guelakais Guelakais force-pushed the gz-math branch 2 times, most recently from 6361eb1 to 2b4c1e6 Compare April 30, 2025 14:46
bengsparks
bengsparks suggested changes May 2, 2025
View reviewed changes
bengsparks
bengsparks suggested changes May 2, 2025
View reviewed changes
bengsparks
bengsparks suggested changes May 3, 2025
View reviewed changes
bengsparks
bengsparks suggested changes May 14, 2025
View reviewed changes
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label May 27, 2025
@Guelakais
Copy link
Contributor Author

Buildint the default gz-math and the python313Packages.gz-math Package does work now!

@Guelakais Guelakais requested a review from bengsparks May 27, 2025 11:12
@nix-owners nix-owners bot requested a review from natsukium May 27, 2025 11:13
@github-actions github-actions bot removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels May 27, 2025
bengsparks
bengsparks suggested changes May 27, 2025
View reviewed changes
@Guelakais Guelakais requested a review from bengsparks July 5, 2025 14:13
@bengsparks bengsparks removed their request for review July 8, 2025 12:51
@Guelakais Guelakais requested a review from bengsparks July 18, 2025 23:52
@Guelakais
Copy link
Contributor Author

Guys, we've been messing around with this pull request for three months now. What else is missing?

@bengsparks bengsparks removed their request for review July 23, 2025 23:32
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5755

@SuperSandroBot
Copy link

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 401753

Logs: https://github.com/SuperSandro2000/nixpkgs-review-gha/actions/runs/16923259329

x86_64-linux

✅ 3 packages built:
  • gz-math
  • python312Packages.gz-math (python313Packages.gz-math)
  • python312Packages.gz-math.python (python313Packages.gz-math.python)

aarch64-linux

✅ 3 packages built:
  • gz-math
  • python312Packages.gz-math (python313Packages.gz-math)
  • python312Packages.gz-math.python (python313Packages.gz-math.python)

x86_64-darwin (sandbox = true)

❌ 3 packages failed to build:
  • gz-math
  • python312Packages.gz-math (python313Packages.gz-math)
  • python312Packages.gz-math.python (python313Packages.gz-math.python)

aarch64-darwin (sandbox = true)

❌ 2 packages failed to build:
  • python312Packages.gz-math (python313Packages.gz-math)
  • python312Packages.gz-math.python (python313Packages.gz-math.python)
✅ 1 package built:
  • gz-math
Error logs: `aarch64-darwin`
python312Packages.gz-math 
        Start 136: UNIT_Conversions_TEST
134/139 Test #136: UNIT_Conversions_TEST ..................................   Passed    0.01 sec
        Start 137: check_UNIT_Conversions_TEST
135/139 Test #137: check_UNIT_Conversions_TEST ............................   Passed    0.01 sec
        Start 138: UNIT_Util_TEST
136/139 Test #138: UNIT_Util_TEST .........................................   Passed    0.01 sec
        Start 139: check_UNIT_Util_TEST
137/139 Test #139: check_UNIT_Util_TEST ...................................   Passed    0.01 sec
138/139 Test #135: ruby_TEST.rb ...........................................   Passed    0.07 sec
139/139 Test  #93: UNIT_Stopwatch_TEST ....................................   Passed    2.36 sec

99% tests passed, 2 tests failed out of 139


Total Test time (real) =   2.71 sec


The following tests FAILED:

129 - GaussMarkovProcess_TEST.rb (Failed)

130 - Rand_TEST.rb (Failed)

Errors while running CTest

make: *** [Makefile:71: test] Error 8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethancedwards8 ethancedwards8 Awaiting requested review from ethancedwards8

@natsukium natsukium Awaiting requested review from natsukium

2 more reviewers

@nim65s nim65s nim65s left review comments

@bengsparks bengsparks bengsparks requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Guelakais @nixos-discourse @SuperSandroBot @nim65s @bengsparks @ethancedwards8