pythonp313Packages.rospkg: init at 1.6.0 #401730
Conversation
|
Your title contains a typo |
|
Guys, seriously, what you're doing here is a packet of broken stuff. |
|
Ah, if |
|
So I've thought about it again and decided that I simply don't have the brainpower to make the cli of this package work. From now on, I will only accept suggestions for improvements that involve making the package available in a meaningful way. So more tests or a more elegant access to the library api. Since I am primarily a ros2 developer, I have never had anything to do with So if there are no more tests that need to be added, the package is declared ready at this point. |
|
Guys, we've been messing around with this pull request for three months now. What else is missing? |
| @@ -0,0 +1 @@ | |||
| export ROS_OS_OVERRIDE=nixos | |||
There was a problem hiding this comment.
this almost certainly should be in env instead
There was a problem hiding this comment.
No. this would produce the following:
this derivation will be built:
/nix/store/zm4k40jdzacq259hfyx97rrh6razsbyq-python3.13-rospkg-1.6.0.drv
building '/nix/store/zm4k40jdzacq259hfyx97rrh6razsbyq-python3.13-rospkg-1.6.0.drv'...
error: builder for '/nix/store/zm4k40jdzacq259hfyx97rrh6razsbyq-python3.13-rospkg-1.6.0.drv' failed with exit code 1;
last 25 log lines:
> E + TrueOs
>
> test/test_rospkg_os_detect.py:544: AssertionError
> ____________________________ test_OsDetect_nomatch _____________________________
>
> def test_OsDetect_nomatch():
> from rospkg.os_detect import OsDetect, OsNotDetected
> detect = OsDetect([('Dummy', FalseOs())])
> assert isinstance(detect.get_detector('Dummy'), FalseOs)
> try:
> detect.get_name()
> > assert False
> E assert False
>
> test/test_rospkg_os_detect.py:590: AssertionError
> =============================== warnings summary ===============================
> test/test_rospkg_os_detect.py::test_osx
> /nix/store/ks4p9h25ksa8ljgaykq1ff7z095aml4i-python3.13-rospkg-1.6.0/lib/python3.13/site-packages/rospkg/os_detect.py:351: DeprecationWarning: distutils Version classes are deprecated. Use packaging.version instead.
> ver = distutils.version.StrictVersion(version).version
>
> -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
> =========================== short test summary info ============================
> FAILED test/test_rospkg_os_detect.py::test_OsDetect_single - AssertionError: assert 'TrueOs' == 'nixos'
> FAILED test/test_rospkg_os_detect.py::test_OsDetect_nomatch - assert False
> =================== 2 failed, 92 passed, 1 warning in 0.81s ====================
For full logs, run:
nix log /nix/store/zm4k40jdzacq259hfyx97rrh6razsbyq-python3.13-rospkg-1.6.0.drv
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.