openwebrx: 1.2.2 -> 1.2.82, switch to github.com/luarvique fork #401555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7d7f65a to
54e9648
Compare
13 tasks
54e9648 to
c9db4dd
Compare
13 tasks
astro
suggested changes
May 16, 2025
| owner = "luarvique"; | ||
| repo = "openwebrx"; | ||
| rev = "0e13d5f290430d127cf0accd4e3c29e7435ee645"; | ||
| hash = "sha256-fwU1aMsjMMiq3zffFs8tksnR5bhTdeoeDQTaaLM0p7M="; | ||
| }; | ||
|
|
||
| propagatedBuildInputs = [ |
There was a problem hiding this comment.
Use dependencies instead of propagatedBuildInputs? I'm not a Python person.
In #347566 I noticed that this fork supports even more decoders. Could you please add at least dablin, hamlib and multimon-ng here? They're already available in nixpkgs. To verify you can check OpenWebRX' decoder status page.
There was a problem hiding this comment.
The decoders are detected on runtime and called as Unix commands from python.
They are not needed for the build.
Some users may want to run openwebrx servers without some of the decoders.
How about removing the optional decoders and utilities from the build
and moving them to nixos/modules/services/web-apps/openwebrx.nix ?
9bbcc96 to
24c6f62
Compare
Co-authored-by: Arne Keller <arne.keller@posteo.de>
Co-authored-by: Arne Keller <arne.keller@posteo.de>
Co-authored-by: Arne Keller <arne.keller@posteo.de>
022e4df to
f295806
Compare
Also add extra decoders to service definition.
f295806 to
67d0740
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to the fork at github.com/luarvique fork.
Update openwebrx from 1.2.2 to 1.2.82.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.