Skip to content

Conversation

detroyejr
Copy link
Contributor

Things done

Similar to the plex for desktop application in nixpkgs already, but we get an interface that's a little nicer for TV's and hand held devices like the steam deck. Practically the same build/install instructions as plex-desktop so it shouldn't be much more in terms of maintenance.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 21, 2025
@Gerg-L
Copy link
Contributor

Gerg-L commented May 3, 2025

it builds, but does not run on my system.
no error or anything, just exits.

Is there something i'm missing?

@detroyejr
Copy link
Contributor Author

detroyejr commented May 3, 2025

Thanks for testing! Made a quick change since I just realized plex-desktop and plex-htpc use the same ~/.local/share path but that may not fix the issue you're seeing. Does plex-desktop have the same launching issue?

EDIT: I've cleared out my ~/.local/share/plex folder to make sure things work with a fresh instance and there doesn't seem to be anything wrong. Does it log anything to ~/.local/share/plex/Logs/Plex HTPC.log?

@Gerg-L
Copy link
Contributor

Gerg-L commented May 3, 2025

ah yeah, same error for both

ERROR - Fatal error: qrc:/views/WebWindow.qml: module "gtk2" is not installed

@detroyejr
Copy link
Contributor Author

Got it. Thanks for the report. Maybe we can simply add gtk2 to the buildFHSEnv. I'd be curious if adding something like

  # Plex needs this to login/click on links.
  xdg.portal = {
    enable = true;
    extraPortals = [ pkgs.xdg-desktop-portal-gtk ];
    xdgOpenUsePortal = true;
  };

to your nixos config works too. Will look into this a little more and see if I can find something.

@Notarin
Copy link
Contributor

Notarin commented May 4, 2025

Thank you for this pr, I have desired to be able to run this for about 8 or so months now and was never able to get it to work myself.
Also, stylix breaks this package, the QT_STYLE_OVERRIDE env var is set to kvantum, which for whatever reason panics both plex-htpc, as well as plex-desktop.
Setting it to "default" worked for me.

@detroyejr
Copy link
Contributor Author

Added unset QT_QPA_PLATFORM QT_STYLE_OVERRIDE to fix this. If people are certain that they want this set to something, overriding extraEnv should still works:

plex-desktop.override {
  extraEnv = { QT_QPA_PLATFORM="wayland"; };
}

Reproduced with QT_STYLE_OVERRIDE=gtk result/bin/plex-htpc and this now no longer causes plex to crash as before.

Copy link
Contributor

@Gerg-L Gerg-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label May 4, 2025
@Notarin
Copy link
Contributor

Notarin commented May 7, 2025

Lets gooo! @detroyejr thank you! I am so hyped to finally be able to use this! I know others who are hyped for this too.
+1

@shikipawz
Copy link

+1
ive been waiting on this for a while @detroyejr thanks for this pr

@detroyejr detroyejr changed the title plex-htpc: init at 1.70.1 plex-htpc: init at 1.71.0 Jun 26, 2025
@detroyejr
Copy link
Contributor Author

Fixed two build issues after bumping including what was addressed in #418546. Runs fine and there aren't any other issues I've spotted. If anyone has feedback, just let me know! I'll make another request in the review channel soon and maybe we can get this merged.

@Notarin
Copy link
Contributor

Notarin commented Aug 16, 2025

Bump.
Really want to remove the extra nixpkgs from my config.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2513

@detroyejr detroyejr changed the title plex-htpc: init at 1.71.0 plex-htpc: init at 1.71.1 Aug 18, 2025
@detroyejr detroyejr requested a review from JamieMagee August 18, 2025 17:06
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Aug 18, 2025
@detroyejr
Copy link
Contributor Author

Thanks for the review! There's an open issue I plan to address (#434341) if it lands on the main branch before this is merged. Otherwise, I'll open a PR against staging-next like we did for #434467.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants